-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ray-packages v2.10.0 #152
ray-packages v2.10.0 #152
Conversation
…nda-forge-pinning 2024.03.19.15.37.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I updated the recipe:
`diff between ray-2.9.3 and ray-2.10.0diff --git a/python/setup.py b/python/setup.py
index b846fb2cac..0ae613aaef 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -49,7 +49,7 @@ CLEANABLE_SUBDIRS = [
# In automated builds, we do a few adjustments before building. For instance,
# the bazel environment is set up slightly differently, and symlinks are
-# replaced with junctions in Windows. This variable is set e.g. in our conda
+# replaced with junctions in Windows. This variable is set e.g. in our conda-forge
# feedstock.
is_automated_build = bool(int(os.environ.get("IS_AUTOMATED_BUILD", "0")))
@@ -227,11 +227,7 @@ ray_files += [
if setup_spec.type == SetupType.RAY:
pandas_dep = "pandas >= 1.3"
numpy_dep = "numpy >= 1.20"
- if sys.platform != "win32":
- pyarrow_dep = "pyarrow >= 6.0.1"
- else:
- # Serialization workaround for pyarrow 7.0.0+ doesn't work for Windows.
- pyarrow_dep = "pyarrow >= 6.0.1, < 7.0.0"
+ pyarrow_dep = "pyarrow >= 6.0.1"
setup_spec.extras = {
"data": [
numpy_dep,
@@ -247,7 +243,6 @@ if setup_spec.type == SetupType.RAY:
"colorful",
"py-spy >= 0.2.0",
"requests",
- "gpustat >= 1.0.0", # for windows
"grpcio >= 1.32.0; python_version < '3.10'", # noqa:E501
"grpcio >= 1.42.0; python_version >= '3.10'", # noqa:E501
"opencensus",
@@ -267,9 +262,7 @@ if setup_spec.type == SetupType.RAY:
"uvicorn[standard]",
"requests",
"starlette",
- # Tracking issue: https://github.com/tiangolo/fastapi/discussions/10948
- "fastapi <= 0.108.0",
- "aiorwlock",
+ "fastapi",
"watchfiles",
],
"tune": ["pandas", "tensorboardX>=1.9", "requests", pyarrow_dep, "fsspec"],
@@ -563,13 +556,17 @@ def build(build_python, build_java, build_cpp):
FutureWarning,
)
- if not is_automated_build:
- bazel_precmd_flags = []
if is_automated_build:
- root_dir = os.path.join(
- os.path.abspath(os.environ["SRC_DIR"]), "..", "bazel-root"
- )
- out_dir = os.path.join(os.path.abspath(os.environ["SRC_DIR"]), "..", "b-o")
+ src_dir = os.environ.get("SRC_DIR", False) or os.getcwd()
+ src_dir = os.path.abspath(src_dir)
+ if is_native_windows_or_msys():
+ drive = os.path.splitdrive(src_dir)[0] + "\\"
+ root_dir = os.path.join(drive, "bazel-root")
+ out_dir = os.path.join(drive, "b-o")
+ bazel_flags.append("--enable_runfiles=false")
+ else:
+ root_dir = os.path.join(src_dir, "..", "bazel-root")
+ out_dir = os.path.join(src_dir, "..", "b-o")
for d in (root_dir, out_dir):
if not os.path.exists(d):
@@ -579,9 +576,8 @@ def build(build_python, build_java, build_cpp):
"--output_user_root=" + root_dir,
"--output_base=" + out_dir,
]
-
- if is_native_windows_or_msys():
- bazel_flags.append("--enable_runfiles=false")
+ else:
+ bazel_precmd_flags = []
bazel_targets = []
bazel_targets += ["//:ray_pkg"] if build_python else [] |
…nda-forge-pinning 2024.03.19.15.37.47
osx is failing with a bazel error:
|
The conda rerender has also brought us up to grpc 1.60, which means we need to redo the grpc vending patches. I will take a stab at that over then next few days |
In a separate PR? |
No, it must happen as part of this PR unless we pin grpc back to 1.59 as part of this one. See the changes to the .ci_support files. |
Looks like grpc 1.60.1 uses protobuf v25.0 internally, and that does not work with bazel 5.4.1.
We can:
|
Makes sense, thanks. Let's merge this to get the package out and continue discussions of how to move forward on the ray issue tracker. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8369288867, please use this URL for debugging.