Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add micropip + pyodide-py recipe #20961

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Add micropip + pyodide-py recipe #20961

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21544be
Add micropip recipe
yuvipanda Nov 1, 2022
0a40471
Add two missing package requirements
yuvipanda Nov 1, 2022
aeb2650
Set min version to 3.10
yuvipanda Nov 1, 2022
2793acf
Add pyodide-py as a dependency
yuvipanda Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions recipes/micropip/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{% set name = "micropip" %}
{% set version = "0.1.0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/micropip-{{ version }}.tar.gz
sha256: 46e901e045860443808b9fd5ec7ad2ae7253ba25440c972b6d1d39e8b3f56f8a

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv
number: 0

requirements:
host:
- python >=3.7
- pip
run:
- python >=3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @yuvipanda!

Could you please add the following runtime requirements,
https://github.com/pyodide/pyodide/blob/main/packages/micropip/meta.yaml#L16

Looks like there were missing pyodide/micropip#21 but we also didn't have many users of this package outside of Pyodide so far :)

Copy link
Member

@rth rth Nov 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also https://pypi.org/project/pyodide-py/ is another dependency, you would likely need to package it as well (it's just another pure Python package). The source code is in https://github.com/pyodide/pyodide/tree/main/src/py

Finally, Python 3.7+ is misleading, it actually needs 3.10+ . We could support a broader range of versions if there is demand for it.


test:
imports:
- micropip
commands:
- pip check
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a micropip check command?

From #20961 (comment) :

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westurner I don't think there is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfv what would micropip check check?.

requires:
- pip

about:
home: https://pypi.org/project/micropip/
summary: A lightweight Python package installer for the web
license: MPL-2.0
license_file: LICENSE

extra:
recipe-maintainers:
- yuvipanda