Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify runtime requirements #21

Closed
1 of 2 tasks
rth opened this issue Nov 1, 2022 · 2 comments · Fixed by #38
Closed
1 of 2 tasks

Specify runtime requirements #21

rth opened this issue Nov 1, 2022 · 2 comments · Fixed by #38

Comments

@rth
Copy link
Member

rth commented Nov 1, 2022 •
edited
Loading

Looks like runtime requirements are not properly specified when pip installing this package.

We should

  • specify pyparsing, packaging as runtime dependencies in pyproject.toml
  • add a CI job that tries to install and (at least import it) on the host environment

xref: conda-forge/staged-recipes#20961
@rth rth mentioned this issue Nov 1, 2022
Merged
10 tasks
@yuvipanda
Copy link

Should also specify python >=3.10?

@rth rth mentioned this issue Dec 12, 2022
Merged
@rth
Copy link
Member Author

rth commented Dec 12, 2022

Yes, good point thanks @yuvipanda !

@rth rth closed this as completed in #38 Dec 12, 2022
rth added a commit that referenced this issue Dec 12, 2022
@rth
Fix minimum Python requirement in pyproject.toml (#38)
bf8f8cf 
Closes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minimum Python requirement in pyproject.toml rth/micropip
2 participants
@yuvipanda @rth