Another attempt to package qsv written in rust #24081
Open
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Not a good start, but should be an easy one to fix:
|
This fix this: error: Using `cargo install` to install the binaries for the package in current working directory is no longer supported, use `cargo install --path .` instead. Use `cargo build` if you want to simply build the package.
* qsv 18.0 recipe * second try patterned after ripgrep recipe https://github.com/conda-forge/ripgrep-feedstock/tree/master/recipe * we don't have pcre2 feature * remove unneeded strip and add missing_dso_whitelist * added libm.so.6 to whitelist * run qsv test without parameters * remove --locked from cargo install let cargo figure out platform-specific dependencies instead of using cargo.lock file. Also restored --help parm to qsv test. The linux and macos errors were caused by something else (regex not being parsed properly by regex crate in docopt crate), which may be caused by cargo --locked parm above. * Try with pcre2 reqt * Try with 0.18.2 which now uses docopt v.1.1.0, bringing back all docopt regex features * with pcre2 * Try for qsv 0.21.0 * tweaks to compile on macos * try macOS specific build options * Explicitly setup rust target for macOS * install rust-std for darwin/osx * no rustup * turn on backtrace so we can debug problem * Another MacOS build attempt w/ qsv 0.24.1 and per @peterjc suggestion * Update sha256 checksum * Specify features * try again with 0.30.1 * do rustup update as MSRV is 1.58.1 * retry installing rust 1.58.1 via meta.yaml * try again with 0.31.0 * try specifying rust version * try with conda branch archive with MSRV set to 1.58 * need python 3.8 for `py` command * Add python 3.8 as a run requirement per lint * Don't specify python version * need python in build stage * update cargo install command - remove python,lua - add luau,fetch,polars,geocode,to - add --locked option * first try for 0.114.0 - update source and hash - remove python from build and run
|
New error on linux: Will revert to 0.114.0 which does accept rust 1.72.0 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/qsv:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Looks like an (indirect) dependency on C++. |
|
Hi @peterjc , you may want to remove the Another feature you may consider removing is the |
|
Another C++ dependency, |
|
Looks like it builds on Linux now, then: Failed to link on macOS: And on Windows failing to compile dependency hashbrown: |
|
The linux failure looks like very much like conda/conda-build#4787 |
|
The Windows failure looks to be something rust specific - https://doc.rust-lang.org/error_codes/E0554.html - maybe @jqnatividad can interpret that?: |
jqnatividad
reviewed
Oct 3, 2023
recipes/qsv/bld.bat
Outdated
| cargo-bundle-licenses --format yaml --output THIRDPARTY.yml | ||
|
|
||
| :: build | ||
| cargo install --root "%LIBRARY_PREFIX%" --path . --all-features || goto :error |
There was a problem hiding this comment.
@peterjc , as I understand it, bld.bat is used to build for Windows.
I'd change this line to:
cargo install --root "$PREFIX" --path . --locked --features feature_capable,apply,generate,foreach,fetch,geocode
There was a problem hiding this comment.
the --all-features option here explains why hashbrown is being built with nightly, as we do have a nightly feature in qsv Cargo.toml.
There was a problem hiding this comment.
Ah yes, I overlooked the Windows options were in a separate file.
Also changing the root path as per Joel's suggestion.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).Continues earlier efforts including #16513