Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another attempt to package qsv written in rust #24081

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Another attempt to package qsv written in rust #24081

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80d53ce
qsv v0.17.3 based on xsv v0.13.0 recipe
peterjc Oct 14, 2021
9a1673e
fix name
peterjc Oct 14, 2021
e3afdaa
Use cargo install --path .
peterjc Oct 14, 2021
22d4357
Explicitly require C on Unix
peterjc Oct 14, 2021
3f37c3b
Qsv (#1)
jqnatividad Sep 26, 2023
9bd0d20
Fix checksum and bump to 0.115.0
peterjc Sep 26, 2023
62542c0
Drop back to v0.114.0 which accepted rust 1.72.0
peterjc Sep 26, 2023
7f7276e
Whitespace fix
peterjc Sep 26, 2023
1ca26a6
Drop polars and to features (dependencies)
peterjc Sep 28, 2023
c392ce4
Drop lua dependency
peterjc Sep 30, 2023
3519a79
Match features on Linux and macOS
peterjc Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions recipes/qsv/bld.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
:: check licenses
cargo-bundle-licenses --format yaml --output THIRDPARTY.yml

:: build
cargo install --root "%LIBRARY_PREFIX%" --path . --all-features || goto :error
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterjc , as I understand it, bld.bat is used to build for Windows.

I'd change this line to:
cargo install --root "$PREFIX" --path . --locked --features feature_capable,apply,generate,foreach,fetch,geocode

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the --all-features option here explains why hashbrown is being built with nightly, as we do have a nightly feature in qsv Cargo.toml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I overlooked the Windows options were in a separate file.


:: remove extra build file
del /F /Q "%LIBRARY_PREFIX%\.crates.toml"

goto :EOF

:error
echo Failed with error #%errorlevel%.
exit 1
20 changes: 20 additions & 0 deletions recipes/qsv/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/usr/bin/env bash

set -o xtrace -o nounset -o pipefail -o errexit

cargo-bundle-licenses \
--format yaml \
--output THIRDPARTY.yml

# build statically linked binary with Rust
# with different parms for Linux and macOS
os_type=$(echo $OSTYPE | cut -c 1-6)
if [[ "$os_type" == "darwin" ]]; then
export RUST_BACKTRACE=full
cargo install --root "$PREFIX" --path . --no-default-features --locked --target x86_64-apple-darwin --features feature_capable,apply,generate,foreach,fetch,geocode
else
cargo install --root "$PREFIX" --path . --locked --features feature_capable,apply,generate,foreach,fetch,geocode
fi

# remove extra build file
rm -f "${PREFIX}/.crates.toml"
47 changes: 47 additions & 0 deletions recipes/qsv/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{% set version = "0.114.0" %}

package:
name: qsv
version: {{ version }}

source:
url: https://github.com/jqnatividad/qsv/archive/refs/tags/{{ version }}.tar.gz
sha256: 12fa3b54ff805ef9b6e72b29d8355b5b4085a8cda4042a1be790ddd1dca7945b

build:
number: 0
missing_dso_whitelist:
- /lib64/libutil.so.1
- /lib64/libpthread.so.0
- /lib64/libc.so.6
- /lib64/libdl.so.2
- /lib64/librt.so.1
- /lib64/libm.so.6

requirements:
build:

host:
- {{ compiler('rust') }}
- rust >=1.72.0
- {{ compiler('c') }} # [not win]
- {{ compiler('m2w64_c') }} # [win]
- cargo-bundle-licenses
- rust-std-x86_64-apple-darwin # [osx]
run:


test:
commands:
- RUST_BACKTRACE=full qsv --version > /dev/null

about:
home: https://github.com/jqnatividad/qsv
license: MIT
license_file: LICENSE-MIT
summary: A fast CSV toolkit written in Rust, a fork from BurntSushi's XSV.

extra:
recipe-maintainers:
- peterjc
- jqnatividad
Loading