Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for warp-lang #24493

Merged
merged 22 commits into from
Dec 8, 2023
Merged

Add recipe for warp-lang #24493

merged 22 commits into from
Dec 8, 2023

Conversation

flferretti
Copy link
Contributor

@flferretti flferretti commented Nov 14, 2023

This PR adds a recipe for for the warp-lang package.

Repo: https://github.com/NVIDIA/warp
PyPI: https://pypi.org/project/warp-lang

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/warp-lang) and found some lint.

Here's what I've got...

For recipes/warp-lang:

  • The home item is expected in the about section.
  • The summary item is expected in the about section.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/warp-lang:

  • The pypa build package has been renamed to python-build.

Remove unnecessary dependencies, pin Python version, update about section
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/warp-lang) and found it was in an excellent condition.

@flferretti
Copy link
Contributor Author

@traversaro would you like to be added to maintainers?

@flferretti flferretti marked this pull request as draft November 14, 2023 11:54
@traversaro
Copy link
Contributor

@traversaro would you like to be added to maintainers?

Ok!

@traversaro
Copy link
Contributor

I see that usd-core is one of the dependencies, probably I also need to revisit #16666 .

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/warp-lang) and found some lint.

Here's what I've got...

For recipes/warp-lang:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/warp-lang) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/warp-lang) and found it was in an excellent condition.

@flferretti
Copy link
Contributor Author

flferretti commented Nov 20, 2023

@conda-forge/help-python-c, @conda-forge/help-python, @conda-forge/staged-recipes the PR is ready for review, thanks!

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@flferretti
Copy link
Contributor Author

@conda-forge/help-python-c, @conda-forge/help-python, @conda-forge/staged-recipes the PR is ready for review after some license fixes, thanks!

recipes/warp-lang/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filippo, et al! 🙏

Had a couple questions below on CUDA usage

recipes/warp-lang/meta.yaml Show resolved Hide resolved
recipes/warp-lang/meta.yaml Show resolved Hide resolved
@xhochy xhochy merged commit 24614e3 into conda-forge:main Dec 8, 2023
5 checks passed
@flferretti flferretti deleted the patch-3 branch June 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants