WIP: Add a metapackage to select BLAS #525
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| {% set blas_pkg = "openblas" %} | ||
|
|
||
| {% set version = "1.0.0" %} | ||
| {% set build_number = 0 %} | ||
|
|
||
| {% set version_post = (".post" + build_number|string) if build_number|int != 0 else "" %} | ||
| {% set version_full = version + version_post %} | ||
|
|
||
|
|
||
| package: | ||
| name: blas | ||
| version: {{ version_full }} | ||
|
|
||
| build: | ||
| # Do not change the build number here. | ||
| number: 0 | ||
|
There was a problem hiding this comment. This feels sort of silly to me, but we now require build numbers for good reasons in other recipes. Unfortunately, they just are not appropriate here as they will not show up in package filename because we are changing the build string. |
||
| string: {{ blas_pkg }} | ||
|
|
||
| requirements: | ||
| run: | ||
| - {{ blas_pkg }} | ||
|
|
||
| test: | ||
| commands: | ||
| - conda list -n _test blas | ||
|
There was a problem hiding this comment. Setting the environment here feels like a horrific hack and quite fragile. Unfortunately, not setting it runs into this issue ( conda/conda-build#910 ). So, not really sure there is another option ATM. |
||
|
|
||
| about: | ||
| home: NA | ||
|
There was a problem hiding this comment. Maybe you can add this pull url as a homepage. So that people see it later can read about it. There was a problem hiding this comment. We were thinking of adding some document to explain how this works and then linking to it. Though we can certainly consider linking from there to the PR. |
||
| license: NA | ||
| summary: Metapackage to select the BLAS `{{ blas_pkg }}`. | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - jakirkham | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my attempt to still have build numbers, but honestly it feels like a waste and still doesn't quite solve the real problem. I'd be happy to drop this stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really would encourage you not to strive so hard to treat these like normal packages. They're definitely not, and it would be just fine to define a separate standard for them. In fact, if this works well, we may bury some of these details into conda syntactic sugar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so, I'm kind of drawing attention to this so people here also agree this is an ugly mess and figure out some better way here or in our infrastructure to address this.
That would be awesome. Maybe it can be what features simply weren't.