Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tardis recipe. #7934

Merged
merged 66 commits into from
Jun 17, 2019
Merged

Added tardis recipe. #7934

merged 66 commits into from
Jun 17, 2019

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Mar 7, 2019

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found some lint.

Here's what I've got...

For recipes/tardis:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found some lint.

Here's what I've got...

For recipes/tardis:

  • The home item is expected in the about section.

For recipes/tardis:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found some lint.

Here's what I've got...

For recipes/tardis:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found some lint.

Here's what I've got...

For recipes/tardis:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found some lint.

Here's what I've got...

For recipes/tardis:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found it was in an excellent condition.

recipes/tardis/meta.yaml Show resolved Hide resolved
recipes/tardis/meta.yaml Show resolved Hide resolved
recipes/tardis/meta.yaml Show resolved Hide resolved
recipes/tardis/meta.yaml Outdated Show resolved Hide resolved
recipes/tardis/meta.yaml Outdated Show resolved Hide resolved
recipes/tardis/meta.yaml Outdated Show resolved Hide resolved
recipes/tardis/meta.yaml Show resolved Hide resolved
recipes/tardis/meta.yaml Outdated Show resolved Hide resolved
recipes/tardis/meta.yaml Outdated Show resolved Hide resolved
chrisburr and others added 3 commits March 7, 2019 04:03
Co-Authored-By: epassaro <epassaro15@gmail.com>
Co-Authored-By: epassaro <epassaro15@gmail.com>
Co-Authored-By: epassaro <epassaro15@gmail.com>
@wkerzendorf
Copy link

hey guys, I'm the maintainer of TARDIS (a scientific code to simulate supernovae). @epassaro is working with us to get this going on conda-forge (and it already looks really good). What we likely will want to do is install compilers through the compiler conda package (we might want to distribute an open-mp version of TARDIS through this). We also want to pin some of the packages - as they have been tested to give the correct output (particularly pandas). I also want to make sure that we only have one definition file of what packages we need. Is it possible to import an environment yaml file?

@wkerzendorf
Copy link

@epassaro we don't need windows support

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tardis:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardis) and found it was in an excellent condition.

@epassaro
Copy link
Member Author

Hey @chrisburr what do you think about the last recipe?

- pip
- setuptools
- astropy =3
- Cython =0.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be lowercase. Also, is this really that strict or is it >=0.29?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we are really strict - as then we know that it works.

- numpy =1.15
- scipy =1.1
- pandas =0.24
- pyne =0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah! pyne! Crazy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @scopatz - we still use it a lot!

- astropy =3
- numpy =1.15
- scipy =1.1
- pandas =0.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all really that strict?

@wkerzendorf
Copy link

@scopatz @chrisburr if conda-forge does not care - we prefer to stick to pinning the versions relatively strictly. this works within our workflow and tardis will essentially always be the main reason for an environment to exist (essentially no codes depend on TARDIS).

@chrisburr chrisburr merged commit 6466fa1 into conda-forge:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants