-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tardis recipe. #7934
Added tardis recipe. #7934
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardis:
For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-Authored-By: epassaro <epassaro15@gmail.com>
Co-Authored-By: epassaro <epassaro15@gmail.com>
Co-Authored-By: epassaro <epassaro15@gmail.com>
hey guys, I'm the maintainer of TARDIS (a scientific code to simulate supernovae). @epassaro is working with us to get this going on conda-forge (and it already looks really good). What we likely will want to do is install compilers through the compiler conda package (we might want to distribute an open-mp version of TARDIS through this). We also want to pin some of the packages - as they have been tested to give the correct output (particularly pandas). I also want to make sure that we only have one definition file of what packages we need. Is it possible to import an environment yaml file? |
@epassaro we don't need windows support |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tardis:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hey @chrisburr what do you think about the last recipe? |
recipes/tardis/meta.yaml
Outdated
- pip | ||
- setuptools | ||
- astropy =3 | ||
- Cython =0.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be lowercase. Also, is this really that strict or is it >=0.29
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now we are really strict - as then we know that it works.
- numpy =1.15 | ||
- scipy =1.1 | ||
- pandas =0.24 | ||
- pyne =0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah! pyne! Crazy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @scopatz - we still use it a lot!
- astropy =3 | ||
- numpy =1.15 | ||
- scipy =1.1 | ||
- pandas =0.24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these all really that strict?
@scopatz @chrisburr if conda-forge does not care - we prefer to stick to pinning the versions relatively strictly. this works within our workflow and tardis will essentially always be the main reason for an environment to exist (essentially no codes depend on TARDIS). |
No description provided.