Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the workflow to submit a recipe to conda-forge? #5

Closed
ocefpaf opened this issue Sep 20, 2015 · 18 comments
Closed

What is the workflow to submit a recipe to conda-forge? #5

ocefpaf opened this issue Sep 20, 2015 · 18 comments

Comments

@ocefpaf
Copy link
Member

ocefpaf commented Sep 20, 2015

@pelson I want to start packaging geos and shapely in the conda-forge channel.

Should I create a feedstock repo in the conda-forge organization or should I send the recipes here to staged-recipes?
@pelson
Copy link
Member

pelson commented Sep 21, 2015

Should I create a feedstock repo in the conda-forge organization or should I send the recipes here to staged-recipes?

I'm still not certain at this point. I think, given anybody who wants to submit a feedstock would have to request a new repo, it makes sense to submit here, and we manually create the feedstock repos (using conda-smithy) once merged.

Obviously there are still some details to work out, and I've not really taken much time to do so recently - I'll start pulling on this thread more throughout October.

In the meantime, if you didn't have a building mechanism in IOOS, I'd recommend submitting a PR here, but since you do, it might make sense not to duplicate the recipe just yet - your call though.

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 21, 2015

it might make sense not to duplicate the recipe just yet - your call though.

My goal is to deprecate all the IOOS recipes I move to conda-forge to avoid duplication. And then set a copy-script to copy the binaries from conda-forge to the IOOS channel. I want to make conda-forge the canonical place for our recipes.

@pelson
Copy link
Member

pelson commented Sep 21, 2015

I want to make conda-forge the canonical place for our recipes.

👍 - I wholeheartedly agree with that approach. Thankfully we are both in a good position at the moment with our anaconda channels, but the more we can share in terms of recipes (not just between us, but to the wider community) the better.

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 22, 2015

See #6.

I will create the feedstocks later this week.

@jakirkham
Copy link
Member

I am really excited about this. I'd love to contribute recipes here. In particular, I would like to start with a OpenBLAS backed copy of NumPy and SciPy. If you can tell me how you would like me to proceed, I will happily get started.

@pelson
Copy link
Member

pelson commented Oct 2, 2015

In particular, I would like to start with a OpenBLAS backed copy of NumPy and SciPy. If you can tell me how you would like me to proceed, I will happily get started.

I think for those particular cases, it might make sense to go straight for a full feedstock repository for each recipe - that should allow you full control of the build matrix, otherwise it is easy to get bogged down trying to fix OSX, Linux and Windows permutations for all of the Python versions. In terms of getting those feedstocks set up, it isn't too challenging, but it does require a number of manual steps which one of the conda-forge admins need to run through (part of conda-smithy is to automate this process entirely, so that it is effectively an instantaneous step to create a new feedstock repo - alas, that isn't quite complete yet).

Next steps depend on your level of excitement - if you want to get your teeth into this in the next few days, it might be worth trying to submit a PR to staged-recipes in the full knowledge that it will become a standalone feedstock in the near future. Alternatively, if you can wait a week or so, I'll try to improve the automation process, and use this as the kick to get me to finish conda-smithy 😉

@jakirkham
Copy link
Member

Sorry I dropped off the map for a bit. I'd be interested in trying the automated process when you are ready.

@jakirkham
Copy link
Member

@pelson, any word? Still interested in helping.

@pelson
Copy link
Member

pelson commented Feb 10, 2016

@jakirkham - I've updated https://conda-forge.github.io/ a little bit. There is some information in there about contributing.

@jakirkham
Copy link
Member

Thanks @pelson. It is looking pretty polished.

So, my main interest is still getting working a working copy of NumPy and SciPy with OpenBLAS going. It looks like this still does not exist. How do you want me to create the feedstock? I imagine I will need a fair bit of guidance as I am unfamiliar with the process here.

@ajgpitch
Copy link
Contributor

It is not clear from reading this thread what the workflow is. I am trying to follow the instructions on:
https://github.com/conda-forge/conda-smithy
It seems that its necessary to populate the feedstock folder in some way first. I tried adding a meta.yaml, but I still have issues on Step 1 (recipe folder being created recursively).
Should I just add my meta.yaml to 'recipes' or 'ready_recipes' here?

"I've updated https://conda-forge.github.io/ a little bit. There is some information in there about contributing"

The section on contributing could be more clear on how add a new feedstock

@jakirkham
Copy link
Member

Not totally sure how confused you are, @ajgpitch, or exactly on what, but this may help. Also, please correct me if I say something wrong @pelson.

At the bottom of the page there is a selection menu for what to do (admittedly this could be a bit clearer), from that you choose what it is you want to do.

screen shot 2016-02-23 at 0 29 39

When selecting add, it points us to the staged-recipes, which we need to fork.

screen shot 2016-02-23 at 0 36 36

I think the idea is you need a proper recipe folder with these contents ( http://conda.pydata.org/docs/building/recipe.html#conda-recipe-files-overview ), which then goes in the folder called "recipes" in your fork. Here is an example with prompt_toolkit. Then you PR this change back to the one here. Once the PR gets accepted there is some magic that happens behind the scenes and then, if all goes well, packages are built and uploaded to the conda-forge channel.

@ajgpitch
Copy link
Contributor

Thank you so much @jakirkham . Yes, it was the little selection arrow I was missing. All makes perfect sense now. I had already made a fork of staged-recipes, I was just unclear of what to do from there.

Probably goes without saying that I am new to this recipe thing, not having done a conda-build. So thanks for the link on that too.

Pretty sure I should be able to get something working now.

@pelson
Copy link
Member

pelson commented Feb 23, 2016

Thanks for the summary @jakirkham.

Yes, it was the little selection arrow I was missing.

You're not the only one. Clearly my career in UI design isn't going to take off 😄
I'd be thrilled if somebody wanted to submit a design PR to https://github.com/conda-forge/conda-forge.github.io. 👍

@jakirkham
Copy link
Member

Clearly my career in UI design isn't going to take off

Well, it is still a nicer site than I would have designed. ;)

Maybe moving the list widget to the end of the sentence might help. Also, the widget could get some background color like white or something to make it stick out against the background. Just my two cents.

@jankatins
Copy link
Contributor

Why not make each question a headline and add the answer below the headline? Like

I like to...
* _... add a package_ [links to the section below]
* _... report a bug_

# Add a package

... text ...

# Report a bug

... text ...

@pelson
Copy link
Member

pelson commented Mar 14, 2016

I think the original question has now been answered (that and a few others beside). I'm going to close this issue.

@JanSchulz - I'm not averse to the changes proposed, though they would need to be done in a way that was consistent with the styling of the conda-forge.github.io homepage (i.e. not extremely verbose). Happy to take PRs at https://github.com/conda-forge/conda-forge.github.io

@pelson pelson closed this as completed Mar 14, 2016
@jankatins
Copy link
Contributor

See conda-forge/conda-forge.github.io#38

Not sure if I got that right, I've no clue what all the divs mean...

ocefpaf pushed a commit that referenced this issue Jun 11, 2016
@pmlandwehr
Merge pull request #5 from pmlandwehr/master
da48dd4 
Updating pykalman to master
ccordoba12 pushed a commit to ccordoba12/staged-recipes that referenced this issue Jun 29, 2016
@msarahan
Merge pull request conda-forge#5 from mingwandroid/qt5
d224008 
Qt5 VS2008 build fixes.
@astaric astaric mentioned this issue Dec 12, 2016
Merged
pkgw pushed a commit that referenced this issue Sep 20, 2018
@guillochon
Merge pull request #5 from conda-forge/master
6a462aa 
Bring up to date
jentjr pushed a commit to jentjr/staged-recipes that referenced this issue Nov 6, 2018
@mbakker7
Merge pull request conda-forge#5 from jentjr/patch-2
dc063cc 
Delete conda_build_config.yaml
epassaro pushed a commit to epassaro/staged-recipes that referenced this issue Mar 7, 2019
[skip appveyor] Skipping Windows build conda-forge#5.
214655f
dclw29 added a commit to dclw29/staged-recipes that referenced this issue Oct 16, 2021
@dclw29
test conda-forge#5 for passing import
acb5bcc
jakirkham pushed a commit that referenced this issue Apr 12, 2023
@adibbley
Merge pull request #5 from bdice/fix-nvrtc-tests
faf3797 
Fix cuda-nvrtc tests.
traversaro added a commit to traversaro/staged-recipes that referenced this issue Sep 16, 2023
@traversaro
# This is a combination of 5 commits.
9032da4 
# This is the 1st commit message:

Add recipe for the trlib C++ library
# The commit message #2 will be skipped:

# Update meta.yaml

# The commit message #3 will be skipped:

# Update meta.yaml

# The commit message conda-forge#4 will be skipped:

# Update meta.yaml

# The commit message conda-forge#5 will be skipped:

# Create disable_valgrind.patch
traversaro added a commit to traversaro/staged-recipes that referenced this issue Sep 16, 2023
@traversaro
# This is a combination of 13 commits.
b4e6812 
# This is the 1st commit message:

Add recipe for the trlib C++ library
# The commit message #2 will be skipped:

# Update meta.yaml

# The commit message #3 will be skipped:

# Update meta.yaml

# The commit message conda-forge#4 will be skipped:

# Update meta.yaml

# The commit message conda-forge#5 will be skipped:

# Create disable_valgrind.patch

# The commit message conda-forge#6 will be skipped:

# Update meta.yaml

# The commit message conda-forge#7 will be skipped:

# Remove dependency on C++ compiler

# The commit message conda-forge#8 will be skipped:

# Update 23.patch

# The commit message conda-forge#9 will be skipped:

# Update 23.patch

# The commit message conda-forge#10 will be skipped:

# Delete recipes/trlib/23.patch

# The commit message conda-forge#11 will be skipped:

# Create 23.patch

# The commit message conda-forge#12 will be skipped:

# Update build.sh

# The commit message conda-forge#13 will be skipped:

# Create win_fix.patch
traversaro added a commit to traversaro/staged-recipes that referenced this issue Sep 16, 2023
@traversaro
# This is a combination of 15 commits.
b0c11bb 
# This is the 1st commit message:

Add recipe for the trlib C++ library
# The commit message #2 will be skipped:

# Update meta.yaml

# The commit message #3 will be skipped:

# Update meta.yaml

# The commit message conda-forge#4 will be skipped:

# Update meta.yaml

# The commit message conda-forge#5 will be skipped:

# Create disable_valgrind.patch

# The commit message conda-forge#6 will be skipped:

# Update meta.yaml

# The commit message conda-forge#7 will be skipped:

# Remove dependency on C++ compiler

# The commit message conda-forge#8 will be skipped:

# Update 23.patch

# The commit message conda-forge#9 will be skipped:

# Update 23.patch

# The commit message conda-forge#10 will be skipped:

# Delete recipes/trlib/23.patch

# The commit message conda-forge#11 will be skipped:

# Create 23.patch

# The commit message conda-forge#12 will be skipped:

# Update build.sh

# The commit message conda-forge#13 will be skipped:

# Create win_fix.patch

# The commit message conda-forge#14 will be skipped:

# Update meta.yaml

# The commit message conda-forge#15 will be skipped:

# Update win_fix.patch
dfm added a commit to dfm/staged-recipes that referenced this issue Apr 23, 2024
@dfm
# This is a combination of 11 commits.
d47ccfe 
# This is the 1st commit message:

Adding recipe for jax-finufft

# This is the commit message conda-forge#2:

Adding finufft license

# This is the commit message conda-forge#3:

Fixing download url

# This is the commit message conda-forge#4:

Correct source hash

# This is the commit message conda-forge#5:

add setuptools_scm

# This is the commit message conda-forge#6:

Trying to work out where dependencies go

# This is the commit message conda-forge#7:

build deps

# This is the commit message conda-forge#8:

double deps

# This is the commit message conda-forge#9:

minimum python version

# This is the commit message conda-forge#10:

Python version constraint

# This is the commit message conda-forge#11:

Adding conda build config
beckermr added a commit that referenced this issue Sep 18, 2024
@beckermr
Merge pull request #5 from beckermr/unify-linting
96f40cd 
test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pelson @jankatins @ocefpaf @jakirkham @ajgpitch