Add config for VS2022

[mariusvniekerk]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

• It looks like the 'vc' output doesn't have any tests.

[mariusvniekerk]

@conda-forge-admin please rerender.

[wolfv]

Thanks for working on this! We just realized that we would also like VS2022 for some STL features that we need for a micromamba patch in order to use the std::filesystem and not a custom implementation.

[mariusvniekerk]

@wolfv @isuruf is this mergeable?

[isuruf]

You need to fix https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat#L94

[mariusvniekerk]

You need to fix https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat#L94

Doesn't this address it https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat#L80 ?

See https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=522229&view=logs&j=00f5923e-fdef-5026-5091-0d5a0b3d5a2c&t=3cc4a9ed-60e1-5810-6eb3-5f9cd4a26dba&l=1165

[isuruf]

No, that's when you have have the visual studio version and the vc version matching. What I'm talking about is when they don't, but you can still target the vc version requested by the user even with a newer visual studio version.

[mariusvniekerk]

Okay, lemme know if that activate is correct, or just push what is needed to this branch

[mariusvniekerk]

@isuruf does this look okay now?

[isuruf]

This is not correct. year has to be deduced from VSINSTALLDIR which can have 2022 for @{year}=2019 or @{year}=2017

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

• It looks like the 'vc' output doesn't have any tests.

[isuruf]

@conda-forge-admin, rerender

[h-vetinari]

Might want to add extra tests for the additional binaries? Like for 2019:

        {% if vsyear == "2019" %}
        - if not exist %LIBRARY_BIN%\vcruntime140_1.dll exit 1
        - if not exist %LIBRARY_BIN%\msvcp140_atomic_wait.dll exit 1
        - if not exist %LIBRARY_BIN%\msvcp140_codecvt_ids.dll exit 1
        {% endif %}

[isuruf]

? which additional binaries are you talking about?

[h-vetinari]

? which additional binaries are you talking about?

MS doesn't touch vcruntime140.dll for forwards-compatibility reason of old code, that's why VS2019 had some pure additions, e.g. vcruntime140_1.dll / msvcp140_atomic_wait.dll / msvcp140_codecvt_ids.dll.

I thought it was quite likely that VS2022 would have some more additional DLLs for the same reason, but if I read the logs right, no new DLLs were added after all, i.e.

Found DLL: concrt140.dll
Found DLL: msvcp140.dll
Found DLL: msvcp140_1.dll
Found DLL: msvcp140_2.dll
Found DLL: msvcp140_atomic_wait.dll
Found DLL: msvcp140_codecvt_ids.dll
Found DLL: vcamp140.dll
Found DLL: vccorlib140.dll
Found DLL: vcomp140.dll
Found DLL: vcruntime140.dll
Found DLL: vcruntime140_1.dll

should all be covered by the current tests.