Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noarch: python for Python packages #128

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Aug 18, 2023

As the XGBoost Python packages are pure Python (using ctypes to interact with the libxgboost library), there is no need to build these for every Python version and architecture. So simply mark these as noarch: python to get the minimum needed builds and move on.


Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #127.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #127

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

conda-forge-webservices[bot] and others added 2 commits August 18, 2023 23:37
As the XGBoost Python packages are pure Python (using `ctypes` to
interact with the `libxgboost` library), there is no need to build these
for every Python version and architecture. So simply mark these as
`noarch: python` to get the minimum needed builds and move on.
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham jakirkham changed the title MNT: rerender Use noarch: python for Python packages Aug 19, 2023
@jakirkham
Copy link
Member

@hcho3 , could you please review? 🙂

@jakirkham
Copy link
Member

We could consider dropping some of the Python mutex packages at this point since really only selecting libxgboost matters for that case. Maybe even revive PR ( #35 ). Though maybe this is easier to do in conjunction with 2.0.0?

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@jakirkham jakirkham mentioned this pull request Oct 20, 2023
5 tasks
@hcho3 hcho3 mentioned this pull request Oct 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please re-render
3 participants