-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds login/logout commands #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! I love where this is going <3
After a discussion with @kenodegard yesterday, we decided against the decorator pattern for the class methods. This would put too much burden on the subclass authors to remember to always put those there. Instead we now simply run them inside the base class' I attempted to solely rely on Part of that was changing how secret retrieval works. There is now an abstract The API has now been improved so that fetching a secret for a channel is simpler. There is now |
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@kenodegard and @jezdez, I believe this is ready for another round of review. On top of making the refactor changes requested, I have also rearranged the command namespace. |
a670528
to
3215143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving where this is going, only smaller API questions!
Fixes: #2