Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build recipes in given order, not alphabetically sorted order #4133

Closed
kurtschelfthout opened this issue Nov 18, 2020 · 5 comments
Closed

Build recipes in given order, not alphabetically sorted order #4133

kurtschelfthout opened this issue Nov 18, 2020 · 5 comments
Labels
stale [bot] marked as stale due to inactivity

Comments

@kurtschelfthout
Copy link
Contributor

kurtschelfthout commented Nov 18, 2020

Actual Behavior

conda build recipeB/ recipeA/ first builds recipeA, then recipeB.

Expected Behavior

It should build in the order given, i.e. recipeB first.

This is important if recipeA has a dependency on recipeB - in that case with the sorted order the build fails.

This happens because of the sorted here:

sorted(recipes),

It should just be left out.

This behavior changed in 3.20 and upwards, was working fine in 3.19 and before.

@mingwandroid
Copy link
Contributor

I agree with you here; though actually conda-build could do even better, it could do a topological sort on the (rendered) recipes' dependencies.

Pinging @njalerikson for his thoughts.

@kurtschelfthout
Copy link
Contributor Author

Thanks for the prompt attention.

it could do a topological sort on the (rendered) recipes' dependencies.

I suggest making sure conda-build respects the order of the given positional arguments first ;) I classify current behavior as a bug, and topological sort as a new feature.

Generally it's intuitive if conda build A B is the same as conda build A & conda build B.

@kenodegard
Copy link
Contributor

I agree.

I would remove the sorting and if we do look into topological (or other) sorting that would be a new feature and likely hidden behind a flag (--sort=[none,alpha,topo,...]).

mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 20, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 20, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 26, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 26, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 26, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Nov 26, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 1, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 15, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 15, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 15, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 15, 2020
mingwandroid pushed a commit that referenced this issue Dec 15, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Dec 15, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Jan 10, 2021
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 15, 2023
@kenodegard
Copy link
Contributor

Resolved in #4134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

3 participants