Activate in build scripts, rather than trying to have Python manage env

[msarahan]

The gist of this is that trying to have Python record the environment variable changes from activation was prone to all sorts of variable corruption. Rather than deal with that, we just call the activation scripts in the build scripts (by prepending this activation bit into a copy of the build script)

Fixes #1040 #1042

cc @havocp

[codecov-io]

Current coverage is 14.9%

Merging #1044 into master will decrease coverage by <.1%

@@             master      #1044   diff @@
==========================================
  Files            43         43          
  Lines          5512       5481    -31   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            825        819     -6   
+ Misses         4687       4662    -25   
  Partials          0          0          

Powered by Codecov. Last updated by cfab2f9...0723172

[msarahan]

wow! first all-green appveyor in a long time! Merging.

[marscher]

I'm not 100% sure if this PR introduced this new failure on Windows (Appveyor):
https://ci.appveyor.com/project/rmcgibbo/conda-recipes/build/1.0.930/job/iumjxgiw762xn0cu#L258

Somehow the variables exported by Visual Studios vcsvars.bat script got omitted... It seems it only affects 64bit systems:

https://ci.appveyor.com/project/marscher/pyemma/build/1.0.2097

[msarahan]

Interesting. It passed our tests locally. Must be something with the alternative compilers.

I know the change involved and will revert it until I fix it.

[marscher]

We're using VS2015 on Appveyor if that helps. My guess is that is has something to do with the way conda-build treats env variables.

[msarahan]

We tried to use distutils for finding and getting the compiler environment
variables. It would make things much simpler, and we hoped more reliable,
because it uses the registry to find installations.

I think it's still a good idea, just not ready for prime time.

On Thu, Jun 23, 2016, 07:30 Martin K. Scherer notifications@github.com
wrote:

We're using VS2015 on Appveyor if that helps. My guess is that is has
something to do with the way conda-build treats env variables.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1044 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AACV-cTcKOHxcrt8IgYwwqNbUuhabTrCks5qOnx4gaJpZM4I7WRY
.

[marscher]

yeah, sounds like a neat idea. Maybe setuptools is better suited (since it is modern) and also available in every conda installation?