New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get run_exports the slow way #3603
base: main
Are you sure you want to change the base?
Get run_exports the slow way #3603
Conversation
`channeldata.json` only contains one `run_exports` entry for each package; some packages (looking at you `fftw`) have multiple builds with different `run_exports`, so we need to use the slow, robust method of accessing `run_exports` during recipe rendering
I don't think that's the right solution. We should fix channeldata.json - it sounds like it is broken. Can you add a test with your fftw package and your desired output from channeldata.json? |
I think this is fixed in #3611 - closing. I think we may need the build string differentiator as discussed on gitter, though. |
Variants are not fixed by #3611 |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Not stale |
channeldata.json
only contains onerun_exports
entry for each version of each package; some packages (looking at youfftw
) have multiple builds of the same version with differentrun_exports
. This PR naively undoes some recent work to force recipe rendering to use the slow, but robust method of accessingrun_exports
.I'm not sure if this PR is well-motivated, or if there is a better solution to the
run_exports
problem, so I haven't added news entries, but will do if this change is acceptable.