merge channeldata from all urls #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge channeldata from all urls associated with a channel. Previously only the channeldata from the last url examined was returned. closes conda#3610
jjhelmus
commented
Jul 17, 2019
| merge_or_update_dict(channeldata, data) | ||
| channeldata_cache[channel_url] = channeldata | ||
| new_channeldata = {} | ||
| merge_or_update_dict(data, new_channeldata) |
There was a problem hiding this comment.
This line is key, the order is switched so that the collection of all url data comes first (the base argument to merge_or_update) and the channeldata for the URL in the current iteration second.
msarahan
approved these changes
Jul 18, 2019
5 tasks
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge channeldata from all urls associated with a channel. Previously
only the channeldata from the last url examined was returned.
closes #3610