Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos azure #3810

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Macos azure #3810

merged 3 commits into from
Nov 15, 2019

Conversation

mingwandroid
Copy link
Contributor

No description provided.

@marcelotrevisani
Copy link
Member

Hi @mingwandroid ,
I just saw that some tests are failing because of the otool, which I really don't know how it works on osx, osx is not my cup of tea. 😅

ERROR :: Failed to run `/usr/bin/otool`.  Please use `conda` to install `cctools` into your base environment.
         An alternative option for users of macOS is to install `Xcode` or `Command Line Tools for Xcode`.

Should we install that cctools or should we skip the tests which need it?

I just saw that you are appending the conda path to each step, right? Doing the
https://github.com/conda/conda-build/pull/3810/files#diff-fec826feae04e51c0d94076385408bdcR121
eval "$($(Build.StagingDirectory)/miniconda/bin/python -m conda shell.bash hook)"

If you want to improve it you can do something similar which we are doing for windows:

Write-Host "##vso[task.prependpath]$ENV:UserProfile\Miniconda3;$ENV:UserProfile\Miniconda3\Scripts;$ENV:UserProfile\Miniconda3\Library\bin"

Write-Host "##vso[task.prependpath]$ENV:UserProfile\Miniconda3;$ENV:UserProfile\Miniconda3\Scripts;$ENV:UserProfile\Miniconda3\Library\bin"

or if you want to you can let it as it is and I will modify it in a couple of weeks, because I have in my todo list some improvements to do on our Azure pipelines.

@mingwandroid
Copy link
Contributor Author

Is Xcode installed on these images? Does anyone know? It is correct to fail if not, and we should add an xfail test for that probably, that's skipped if Xcode is installed (and not the stub exe), probably just run the test always though so we can do these inspections (does it link with that xcselect dylib?) without creating a new fixture?

@mingwandroid
Copy link
Contributor Author

Can I do proper activation rather than prependingpath? I'm not interested in avoiding activation, it's important we do this correctly.

@marcelotrevisani
Copy link
Member

Can I do proper activation rather than prependingpath? I'm not interested in avoiding activation, it's important we do this correctly.

Sure, as you want to do the activation is better to keep your code then

@marcelotrevisani
Copy link
Member

Is Xcode installed on these images? Does anyone know? It is correct to fail if not, and we should add an xfail test for that probably, that's skipped if Xcode is installed (and not the stub exe), probably just run the test always though so we can do these inspections (does it link with that xcselect dylib?) without creating a new fixture?

Just for future references, the whole description of what is installed on osx 10.13
https://github.com/microsoft/azure-pipelines-image-generation/blob/master/images/macos/macos-10.13-Readme.md

@mingwandroid mingwandroid force-pushed the macos-azure branch 4 times, most recently from ae61754 to e746e74 Compare November 14, 2019 22:27
@mingwandroid
Copy link
Contributor Author

This is ready to go now from my side. A few failures on macOS python 3.8 @jjhelmus .. think they could be showing an issue with our builds.

@mingwandroid
Copy link
Contributor Author

Permissions thing on Windows, ok to merge @msarahan, @marcelotrevisani?

@marcelotrevisani
Copy link
Member

Permissions thing on Windows, ok to merge @msarahan, @marcelotrevisani?

I think so!
I will mark that test as serial in a couple of days.

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Nov 15, 2019

I think that is good to go from my side.
Very nice job @mingwandroid ! Thanks! 😄
for me osx is always a pain to make it work properly

It closes #3756

@mingwandroid mingwandroid merged commit 1c76172 into conda:master Nov 15, 2019
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants