check return code when selecting patch type

[jjhelmus]

Description

When selecting between the .native, .lf, and .crlf patches, do not mark the result as successful if a non-zero (failure) return value was returned.

This also allows platforms whose patch commands do not support the --binary argument, such as FreeBSD, to use patches in recipes.

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?

[jezdez]

Thanks for the patch @jjhelmus, could you add a news item?

[jjhelmus]

Thanks for the patch @jjhelmus, could you add a news item?

Done

[kenodegard]

@jjhelmus the tests are all hanging around the same place (I’ve also rerun the tests twice and get the same issue) so something is wrong with this change

[github-actions]

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

1. Rebase and verify the changes still work
2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

[github-actions]

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

1. Rebase and verify the changes still work
2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!