Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetch lfs files for specific git_ref #5202

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

Tobias-Fischer
Copy link
Contributor

Description

Currently conda-build fetches all lfs files that ever existed in the history. This is not necessary, and as outlined in #4809 is costly when e.g. using GitHub. For the specific use case that I have in mind (see RoboStack/ros-humble#155), the lfs files were actually removed from the repository and moved elsewhere (as the GitHub limits were exceeded, and now require payment), but the conda build still fails.

We already have the git_ref that we are interested in, so this is a relatively minor change; much smaller than making git-lfs completely optional as suggested in #4809

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @Tobias-Fischer.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#881), and ping the bot to refresh the PR.

@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 29, 2024
@Tobias-Fischer
Copy link
Contributor Author

Hi @kenodegard - any chance to run this again, please?

@Tobias-Fischer
Copy link
Contributor Author

I think this is ready to go - all CI failures are unrelated :)

@Tobias-Fischer
Copy link
Contributor Author

A quick reminder @kenodegard :)

@kenodegard
Copy link
Contributor

@Tobias-Fischer thanks for checking in, we're still working to resolve the unrelated test failures caused by upstream deprecations, once we untangle that we'll get this moving again

Copy link

codspeed-hq bot commented Mar 25, 2024

CodSpeed Performance Report

Merging #5202 will not alter performance

Comparing Tobias-Fischer:patch-1 (5a66529) with main (ab137d2)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard changed the title Only fetch lfs files for specific git_ref Only fetch lfs files for specific git_ref Mar 25, 2024
Copy link
Contributor

@schuylermartin45 schuylermartin45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you providing the additional context in the PR notes. This looks pretty straight forward and a good win all-around. Thanks!

@kenodegard kenodegard merged commit 15f3323 into conda:main Mar 25, 2024
28 checks passed
@Tobias-Fischer Tobias-Fischer deleted the patch-1 branch March 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants