Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sys.exit with CondaBuildUserError exceptions #5255

Draft
wants to merge 42 commits into
base: 24.5.x
Choose a base branch
from
Draft

Replace sys.exit with CondaBuildUserError exceptions #5255

wants to merge 42 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 25, 2024 •
edited

Description

Resolves #4209
Resolves #5242

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 25, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 25, 2024 •
edited

CodSpeed Performance Report

Merging #5255 will not alter performance

Comparing kenodegard:remove-sys.exit (1943a58) with 24.5.x (fa90c11)

Summary

✅ 3 untouched benchmarks

This was referenced Mar 27, 2024
Merged
Merged
@jezdez jezdez mentioned this pull request Apr 29, 2024
Merged
3 tasks
@kenodegard kenodegard changed the base branch from main to 24.5.x May 1, 2024 20:22
dependabot bot and others added 14 commits May 6, 2024 21:08
@dependabot @kenodegard
Bump codecov/codecov-action from 4.3.0 to 4.3.1 in /.github/workflows (…
a5a63c7 
…conda#5329)

* Bump codecov/codecov-action from 4.3.0 to 4.3.1 in /.github/workflows

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@8450866...5ecb98a)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@dependabot @kenodegard
Bump actions/checkout from 4.1.4 to 4.1.5 in /.github/workflows (cond…
cf7e02e 
…a#5328)

* Bump actions/checkout from 4.1.4 to 4.1.5 in /.github/workflows

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@0ad4b8f...44c2b7a)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@conda-bot
🔄 synced file(s) with conda/infrastructure (conda#5331)
2afc503 
Co-authored-by: Conda Bot <conda-bot@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (conda#5327)
5c53aa9 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.2...v0.4.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kenodegard
Merge 24.5.x back into main
06cda41
@conda-bot
🔄 synced file(s) with conda/infrastructure (conda#5335)
efb79db 
Co-authored-by: Conda Bot <conda-bot@users.noreply.github.com>
@kenodegard
Add upload.yml workflow (conda#5339)
0311d83
@dependabot @kenodegard
Bump conda/actions from 24.4.0 to 24.5.0 in /.github/workflows (conda…
9c0ceec 
…#5337)

* Bump conda/actions from 24.4.0 to 24.5.0 in /.github/workflows

Bumps [conda/actions](https://github.com/conda/actions) from 24.4.0 to 24.5.0.
- [Release notes](https://github.com/conda/actions/releases)
- [Commits](conda/actions@v24.4.0...976289d)

---
updated-dependencies:
- dependency-name: conda/actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@kenodegard
Add CondaBuildUserError exception
c49957f
@kenodegard
Replace sys.exit in copy_readme
f87ea39
@beeankha @kenodegard
Add test for copy_readme()
c99b53c
@kenodegard
Update test_filter_files
972c9c2
@kenodegard
Remove commented out code
d0587b6
@kenodegard
Remove redundant error checking
fad4399 
Check for any new files within `m.config.meta_dir` is unnecessary since they're already filtered out by `conda_build.utils.filter_files`.
beeankha and others added 24 commits May 20, 2024 22:59
@beeankha @kenodegard
Add news file
baed5da
@kenodegard
Replace sys.exit in handle_anaconda_upload
f8a1906
@kenodegard
Replace sys.exit in inspect_linkages
cb3d6cf
@beeankha @kenodegard
Remove another sys.exit in inspect_linkages(), add test
69f0ce9
@beeankha @kenodegard
Remove sys.exit call in inspect_objects() and add test
b1f035a
@kenodegard
Raise CondaBuildUserError in check_external
44bf3d6
@kenodegard
Format strings
a073f4b
@kenodegard
Fix check_dist_info_version
192b334
@kenodegard
Fix inspect tests
3795a49
@kenodegard
Fix SystemExit tests
cc6e292
@kenodegard
Remove sys.exit from find_lib
e3a2b3d
@kenodegard
Replace sys.exit in osx_ch_link
00062c8
@kenodegard
Update post.py
f1d3b50
@kenodegard
Deprecate exception_on_error
cfb2ef4
@kenodegard
Remove sys.exit from check_symlinks
ddc9f96
@kenodegard
Remove ImportError for PyYAML since it is an explicit dependency
5c457d7
@kenodegard
Fix test
e3e53fc
@kenodegard
Remove sys.exit from select_lines
b886dcf
@kenodegard
Remove sys.exit from sanitize/_git_clean
46563a5
@kenodegard
Remove sys.exit from check_bad_chrs
8e9cbef
@kenodegard
Use PrefixData instead of custom get_installed_packages
8df5156
@kenodegard
Jinaj2 is always installed
e112c64
@kenodegard
Replace sys.exit in _get_contents
5cb28a2
@kenodegard
Remove sys.exit from parse_until_resolved
1943a58
This was referenced May 23, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholth dholth dholth left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kenodegard kenodegard

@beeankha beeankha

Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace using sys.exit with higher level error/logic handling, e.g. custom exception Remove sys.exit calls
4 participants
@kenodegard @dholth @conda-bot @beeankha