Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HashableDict in favor of frozendict #5284

Merged
merged 4 commits into from Apr 15, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Apr 13, 2024

Description

Instead of using a customized HashableDict implementation we can just use the frozendict library (which conda already depends on). Using frozendict also means we can avoid calling deepcopy (frozendict takes care of this for us).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 13, 2024
Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #5284 will not alter performance

Comparing kenodegard:deprecate-hashabledict (ea171c0) with main (b7ea405)

Summary

✅ 3 untouched benchmarks

@kenodegard
Copy link
Contributor Author

kenodegard commented Apr 13, 2024

The current version of frozendict.deepfreeze mutates the original object. This is undesired behavior and needs to be corrected. Hopefully it can be addressed upstream, see Marco-Sulla/python-frozendict#96 & Marco-Sulla/python-frozendict#97.

Resolved upstream, frozendict 2.4.2 has been released.

@kenodegard kenodegard marked this pull request as ready for review April 15, 2024 16:03
@kenodegard kenodegard requested a review from a team as a code owner April 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants