Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate make_immutable in favor of frozendict.deepfreeze #13801

Merged
merged 4 commits into from Apr 18, 2024

Conversation

kenodegard
Copy link
Contributor

Description

Continuing to decrease conda.auxlib's surface area. Also see conda/conda-build#5284 for a similar change in conda-build.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 15, 2024
jezdez
jezdez previously approved these changes Apr 15, 2024
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥶

Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #13801 will not alter performance

Comparing kenodegard:deepfreeze (4c52d4d) with main (a3a51dc)

Summary

✅ 21 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review April 17, 2024 00:12
@kenodegard kenodegard requested a review from a team as a code owner April 17, 2024 00:12
@jezdez jezdez merged commit 0c38f56 into conda:main Apr 18, 2024
66 checks passed
@kenodegard kenodegard deleted the deepfreeze branch April 18, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants