Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few more logger.warn calls #5365

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Jun 10, 2024

Description

In #5364 I missed a few calls to .warn because they were chained with our own get_logger function.
This PR takes care of those.

Checklist - did you ...

Still nothing here applies.

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 10, 2024
@zklaus
Copy link
Contributor Author

zklaus commented Jun 10, 2024

pre-commit.ci autofix

Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #5365 will not alter performance

Comparing zklaus:warn-to-warning-remaining (4211e1d) with main (4561699)

Summary

✅ 3 untouched benchmarks

@zklaus zklaus marked this pull request as ready for review June 10, 2024 13:47
@zklaus zklaus requested a review from a team as a code owner June 10, 2024 13:47
@jezdez jezdez merged commit bf79003 into conda:main Jun 11, 2024
28 checks passed
@zklaus zklaus deleted the warn-to-warning-remaining branch June 11, 2024 11:32
@beeankha beeankha mentioned this pull request Jul 16, 2024
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants