Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support python 3.10 #10970

Merged
merged 6 commits into from
Oct 11, 2021
Merged

support python 3.10 #10970

merged 6 commits into from
Oct 11, 2021

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Oct 6, 2021

Fixes #10969

@isuruf isuruf requested a review from a team as a code owner October 6, 2021 15:49
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 6, 2021
@isuruf isuruf mentioned this pull request Oct 6, 2021
Closed
4 tasks
@mbargull
Copy link
Member

mbargull commented Oct 6, 2021

Thanks for the prompt PR!
Ideally, we could get rid of get_major_minor_version overall in case it turns out that it's only used with dotted version and not paths etc. anyway. If some of the main conda devs could carefully review all get_major_minor_version uses, that'd be very helpful.

chrisburr
chrisburr reviewed Oct 6, 2021
View reviewed changes
conda/common/path.py Outdated Show resolved Hide resolved
@isuruf @chrisburr
One or more digits
e30310b 
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@jezdez jezdez added this to the 4.11.0 milestone Oct 7, 2021
jezdez
jezdez requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @isuruf! This looks like a good approach, although we should do a few things here:

  • add a proper docstring for the function
  • use multiple-digit variable names to easier debugging
  • add code comments to explain why it handles both version strings AND base file paths
  • use double-quotes consistently

@marscher
Copy link

marscher commented Oct 8, 2021

This should be released ASAP, as it breaks 3.10 shebangs for entry points. So pip etc. is currently broken on 3.10

@marscher marscher mentioned this pull request Oct 8, 2021
Merged
7 tasks
@h-vetinari
Copy link

Agreed that this is time-critical. It deserves a point release as soon as it lands. Currently the noarch: python package building in conda-forge is affected by this.

@h-vetinari
Copy link

(alternatively, conda-forge could mark the 3.10 builds as broken until this issue is fixed & released; but given that this PR exists, I'd much prefer moving forward here, if possible)

This was referenced Oct 8, 2021
Merged
Merged
@kenodegard kenodegard mentioned this pull request Oct 11, 2021
Closed
@jezdez jezdez merged commit bc22d85 into conda:master Oct 11, 2021
@isuruf isuruf deleted the 310 branch October 12, 2021 02:31
@h-vetinari
Copy link

Thanks for merging! :)

Would it be possible to get a new release for this?

@xhochy xhochy mentioned this pull request Oct 13, 2021
Merged
5 tasks
@cdeepali cdeepali mentioned this pull request Oct 18, 2021
Closed
jonashaag pushed a commit to jonashaag/conda that referenced this pull request Oct 19, 2021
@isuruf @chrisburr @jonashaag
support python 3.10 (conda#10970)
8c3699d 
* support python 3.10

* use a raw string for regex

* remove unused import

* Fix condition

* One or more digits

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>

* use double quotes and better variable names

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@Illviljan Illviljan mentioned this pull request Oct 30, 2021
Merged
5 tasks
@igor-petrik-invitae
Copy link

Is there a timeline for when a release with this fix will be available?

@jezdez
Copy link
Member

jezdez commented Nov 2, 2021

Is there a timeline for when a release with this fix will be available?

There is: https://github.com/conda/conda/milestone/51

isuruf added a commit to isuruf/conda-feedstock that referenced this pull request Nov 2, 2021
@isuruf
backport conda/conda#10970 patch
6da2942
isuruf added a commit to isuruf/conda-feedstock that referenced this pull request Nov 2, 2021
@isuruf
backport conda/conda#10970 patch
6d9f7cb
isuruf added a commit to isuruf/conda-feedstock that referenced this pull request Nov 2, 2021
@isuruf
backport conda/conda#10970 patch
87432ca
isuruf added a commit to conda-forge/conda-feedstock that referenced this pull request Nov 3, 2021
@isuruf
Merge pull request #154 from isuruf/py310
059ec76 
backport conda/conda#10970 patch
@jakirkham jakirkham mentioned this pull request Nov 3, 2021
Merged
5 tasks
This was referenced Nov 4, 2021
Closed
Closed
@EwoutH
Copy link

EwoutH commented Nov 15, 2021

Is there any chance this PR can be included ASAP in a tagged release, either 4.10.4 or 4.11.0? It's really blocking any adaption of Python 3.10 with Conda.

FaustinCarter pushed a commit to FaustinCarter/conda that referenced this pull request Nov 27, 2021
@isuruf @chrisburr @FaustinCarter
support python 3.10 (conda#10970)
49d9547 
* support python 3.10

* use a raw string for regex

* remove unused import

* Fix condition

* One or more digits

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>

* use double quotes and better variable names

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@chenghlee chenghlee mentioned this pull request Apr 20, 2022
Closed
4 tasks
@stuarteberg stuarteberg mentioned this pull request May 24, 2022
Merged
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisburr chrisburr chrisburr left review comments

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Not compatible with python 3.10
9 participants
@isuruf @mbargull @marscher @h-vetinari @igor-petrik-invitae @jezdez @EwoutH @chrisburr @anaconda-issue-bot