-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for new menuinst; non-win platforms #11035
Conversation
eb45567
to
8708bc2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@kenodegard, I am seeing some environment stacking errors strikingly similar those described in #11257 (comment) and related work (linux integration group 1). I don't get how or why changing menuinst stuff would affect that part of the code but what do I know... do you mind sharing any pointers you might have if you have time at some point? Thank you! |
Well turns out you should NOT install things after |
Continues in #11882 (token needed for canary builds) |
Part of the CEP efforts.
Right now this is using
menuinst
from the experimental builds available atjaimergp/label/menuinst_dev
, which are coming from this other PR (cep
branch).Summary of changes:
on_win
checks for menuinst code paths.menuinst
API, falling back tomenuinst._legacy
when needed.--shortcuts
and--no-shortcuts
CLI flags in non-windows platforms.--shortcuts-only
†‡ flag to CLI and context, which adds better support for constructor'smenu_packages
option.menuinst=2
specific tests in the integration suite† This allows us to remove the
conda-standalone constructor --mk-menus/--rm-menus
code paths, simplifying the patches on the conda-standalone project. Note this can be further simplified by improving theconda run
support onconda-standalone
.‡ This can be implemented with a dual
--shortcuts
too. If shortcuts is set toTrue
(bare--shortcuts
), same behaviour is kept. If the user sets it to a list of packages, then it behaves asshortcuts_only
(e.g.--shortcuts=package_a,package_b
). However, this is trickier to implement (and I am not sure it's even possible without big changes tocontext
/argparse
). Hence why I opted for--shortcuts-only
above: it is one more flag, yes, but maintains better legacy behaviour and we can see precedents for this in the--channel-priority
expansion. Note it can be used several times like--shortcuts-only=python --shortcuts-only=numpy
.