Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Repo plugin prototype #11788

Closed
wants to merge 1 commit into from
Closed

[WIP] Repo plugin prototype #11788

wants to merge 1 commit into from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Sep 1, 2022

Per #11600 (comment)

The goal is to provide a design for the plugin data structures and extract the current implementation to what will become the default implementation plugin.

This PR just implements the data structures and prepares the codebase for the plugin system to be able to hook into it.

TODO:

  • Implement repodata fetching
  • Implement package fetching

After this, we can open a proper PR against the plugins branch.

@FFY00 FFY00 changed the title [WIP] repo: repodata interface [WIP] Repo plugin prototype Sep 1, 2022
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 1, 2022
@beeankha
Copy link
Contributor

beeankha commented Sep 1, 2022

@FFY00 could you please point this PR to the feature/plugins feature branch vs main?

@beeankha
Copy link
Contributor

beeankha commented Sep 1, 2022

(connecting issue #11600)

@FFY00
Copy link
Member Author

FFY00 commented Sep 1, 2022

I have purposely not based this on the plugins branch, as that's fast moving, and I didn't want to have to deal with keeping up with it for the prototype. I'll definitely point at the plugins branch when actually proposing an implementation. Does this sound reasonable to you? Or do you want me to change the approach? 😅

@beeankha
Copy link
Contributor

beeankha commented Sep 1, 2022

I have purposely not based this on the plugins branch, as that's fast moving, and I didn't want to have to deal with keeping up with it for the prototype. I'll definitely point at the plugins branch when actually proposing an implementation. Does this sound reasonable to you? Or do you want me to change the approach? 😅

One reason we might want to point to the feature branch sooner rather than later is so that we can see if everything integrates together well, but I understand not wanting to keep up with a feature branch while things are still in the early stages! 👍

@FFY00 FFY00 force-pushed the features/repo-plugin branch 2 times, most recently from 72116e4 to feead78 Compare September 1, 2022 21:28
@dholth dholth self-requested a review September 1, 2022 21:29
@FFY00 FFY00 mentioned this pull request Sep 6, 2022
2 tasks
@FFY00
Copy link
Member Author

FFY00 commented Sep 8, 2022

The repodata implementation seems to be working properly now, we just need to port the tests and add some backport imports to get the tests to pass.

@jezdez jezdez added the plugins pertains to a plugin/subcommand label Sep 26, 2022
Signed-off-by: Filipe Laíns <lains@riseup.net>
@travishathaway travishathaway linked an issue Oct 6, 2022 that may be closed by this pull request
2 tasks
@dholth
Copy link
Contributor

dholth commented Oct 20, 2022

I'm working on a less dramatic extension of this change at #12003 which introduces gateways.repodata and should pass tests.

I think it will be necessary to get this working as a not-plugin and then refactor it, again, into a plugin once we have several use cases working nicely.

@dholth dholth mentioned this pull request Nov 7, 2022
3 tasks
@travishathaway travishathaway added the source::partner created by or for an Anaconda, Inc. partner company label Dec 5, 2022
@dholth
Copy link
Contributor

dholth commented Jan 18, 2023

Thanks, this was really helpful.

@dholth dholth closed this Jan 18, 2023
@jezdez jezdez deleted the features/repo-plugin branch May 16, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA plugins pertains to a plugin/subcommand source::partner created by or for an Anaconda, Inc. partner company
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create a "fetch" plugin prototype
6 participants