Shell Plugin Prototypes #12721
Open
Shell Plugin Prototypes #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
5 tasks
jezdez
reviewed
May 31, 2023
Updated CLI argument parsing: * Refactored original parsing logic to make `activate`, `deactivate` and `reactivate` sub-parsers * created new _parse_and_set_args method that will override method in parent class * updated conda shell forwarding function for POSIX shells to handle evaluation of statements from plugin that uses current conda logic to carry out activation/deactivation processes --------- Signed-off-by: Katherine Abrikian <kalawac@users.noreply.github.com>
Final commit was missing from previous pull request. Signed-off-by: Katherine Abrikian <kalawac@users.noreply.github.com>
Updated CLI argument parsing: * Refactored original parsing logic to make `activate`, `deactivate` and `reactivate` sub-parsers * created new _parse_and_set_args method that will override method in parent class * updated conda shell forwarding function for POSIX shells to handle evaluation of statements from plugin that uses current conda logic to carry out activation/deactivation processes --------- Signed-off-by: Katherine Abrikian <kalawac@users.noreply.github.com>
Final commit was missing from previous pull request. Signed-off-by: Katherine Abrikian <kalawac@users.noreply.github.com>
travishathaway
force-pushed
the
shell-plugins
branch
from
d310ed3
to
2f03cbe
Compare
kenodegard
reviewed
Jun 7, 2023
Comment on lines
218
to
224
| @hookimpl | ||
| def conda_shell_plugins(): | ||
| yield CondaShellPlugins( | ||
| name="posix_plugin_current_logic", | ||
| summary="Plugin for POSIX shells: handles conda activate, deactivate, and reactivate", | ||
| activator=PosixPluginActivator, | ||
| ) |
There was a problem hiding this comment.
these plugins for the conda_shell_plugins hook aren't used anywhere (yet)
There was a problem hiding this comment.
Yes, the gist indicates that the hook is just a placeholder for the moment. Eventually, there'll be some logic specific to the shell plugins there. I thought it was important to indicate that there probably would be a hook of some kind.
…into shell-plugins-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prototype plugins for spike issue #12621. The prototypes demonstrate three proposed architectural methods for plugins that handle, at minimum, conda's
activate,deactivateandreactivateprocesses. See also the related gist with discussion points and architectural considerations for each prototype scenario.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?