Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging recent failures in test_main_clean.py #13065

Merged
merged 8 commits into from
Sep 9, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Sep 5, 2023

Description

Recent tests have seen tests fail in test_main_clean.py for unrelated changes. This is an effort to continue debugging this issue (and taking the opportunity to update the tests).

See:

(edit) Still unsure why this failure started to occur. The package in question conda-forge::bzip2 hasn't been modified in 2 years. Either way it appears that switching to zlib fixes the problem.

Otherwise this PR also cleans up type hints.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Sep 5, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 5, 2023
@kenodegard kenodegard marked this pull request as ready for review September 9, 2023 00:09
@kenodegard kenodegard requested a review from a team as a code owner September 9, 2023 00:09
@kenodegard kenodegard enabled auto-merge (squash) September 9, 2023 00:46
@kenodegard kenodegard merged commit 0a2244f into conda:main Sep 9, 2023
66 checks passed
@kenodegard kenodegard deleted the test_main_clean-debugging branch September 9, 2023 03:56
@jezdez jezdez mentioned this pull request Sep 26, 2023
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants