prefer log.warning() in conda.gateways.repodata #13108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
beeankha
approved these changes
Sep 18, 2023
jezdez
reviewed
Sep 18, 2023
| warnings.warn(f"{e.__class__.__name__} loading {self.cache_path_state}") | ||
| log.warning(f"{e.__class__.__name__} loading {self.cache_path_state}") |
There was a problem hiding this comment.
The main difference is that warnings.warn will only show up once for the same parameter, while log.warning will emit to the configured log output every occurrence. More infos: https://stackoverflow.com/a/37979724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on #13056. Is it better to use log.warning() over warnings.warn()?
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?