-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More refactoring for plugin manager. #13118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kenodegard
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing pluggy.PluginManager.register
again the only instances where a ValueError
is raised is when the plugin has already been registered. Let's just silently consume this instead of converting it into a PluginError.
kenodegard
reviewed
Sep 19, 2023
kenodegard
reviewed
Sep 19, 2023
kenodegard
reviewed
Sep 19, 2023
kenodegard
reviewed
Sep 19, 2023
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
kenodegard
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
[bot] added once the contributor has signed the CLA
plugins
pertains to a plugin/subcommand
source::anaconda
created by members of Anaconda, Inc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following https://github.com/conda/conda/pull/13057/files#r1328506001 we noticed that #13057 removed the duplication check and makes the plugin loading prone to import time side effects.
Checklist - did you ...
[ ] Add a file to thenews
directory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?