Add response string to repodata JSONDecodeError

[dholth]

Description

Fix #13110

This should make it much easier to figure out what is going on when repodata.json is not parseable.

Do we need to sanitize the response so it can't print HTML or escape characters?

It would be better if we converted this to a CondaError instead of surfacing the Python exception. We could raise a subclass of JSONDecodeError with the data and convert to CondaError at a much higher level?

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?
• Add / update outdated documentation?

[travishathaway]

@dholth,

It think it would be a better idea to address these issues just slightly further up the call stack.

What if instead of returning a JSON string that has be parsed later, fetch_latest always returned a parsed value and we forced it to be dealt with there?

We could also change read_cache to work the same way too. That way we could also separate the error messages so that it's easier for us differentiate invalid JSON coming from a network request vs. coming from bad cache values on disk.

Also, I would expect the error message to look similar to what we have in read_cache right now for problems related to faulty copies of cached data.

In the future, it might also be nice to figure out how to implement some retry logic if a faulty cached version is found (i.e. just remove it and grab another fresh copy from the server).

[dholth]

@travishathaway this was made so that we can have have fetch_latest_path and pass the repodata file to something like libmamba without necessarily parsing.

The user that is having this issue gets the same issue after clearing the cache, their server or firewall may be returning not-json.

[dholth]

Is there a way for me to get the URL here... (without any tokens?)

[jezdez]

Could we create a higher level tool that wraps json.loads or something that would enable us to handle this holistically through out the codebase?

[conda-bot]

Review build status

The workflow for building and uploading a canary release for conda with the label conda-conda-pr-13128 in channel conda-canary was started by @dholth!

Once it's done, use this command to try it out in a new conda environment:

conda install -c conda-canary/label/conda-conda-pr-13128 conda

• build 6303921865 succeeded on macOS (X64)

[dholth]

I'm not sure about a global wrapper for json.loads(). Could be tricky to decide when to keep the input string or figure out where to attach additional useful information such as the URL that produced the unparseable input.

A good followup would be to write a test that adds a bad channel (html-formatted repodata.json) and check that conda still loads any other configured channels.

[dholth]

The customer was able to run this branch and see the beginnings of a HTML document in the traceback. Then we were able to change a URL in condarc.

[codspeed-hq]

CodSpeed Performance Report

Merging #13128 will create unknown performance changes

_{Comparing 13110-improved-jsondecodeerror (a6f2629) with main (9c2a156)}

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

[kenodegard]

pre-commit.ci autofix