New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop importing from conda/exports.py
#13869
Conversation
CodSpeed Performance ReportMerging #13869 will not alter performanceComparing Summary
|
fb0ca24
to
7627971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, but I am not familiar enough with the implications of this change.
@beeankha The description of the PR doesn't match the content of the PR, since it changes only things in |
conda/exports.py
conda/exports.py
I agree that the wording is confusing; I meant we want to remove any import statements that are importing anything from the |
The base branch was changed.
While investigating a fix for #13860, an instance of
reset_context()
was found inconda/exports.py
; in order to avoid resetting the context unintentionally, as well as to avoid utilizing theconda/exports.py
module (which is meant to be used by conda-build vs conda), this PR attempts to remove/edit/update any import statement in the conda codebase that is importing fromconda/exports.py
.Certain cases were left alone, such as the imports from
exports.py
intests/test_create.py
intest_list_with_pip_no_binary
andtest_rm_rf
, since those are specifically related to regression testing.Also related to the following deprecation issue:
conda/plan.py
for Deprecation (and do related refactoring work as necessary) #12421