Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate conda.plan #13881

Merged
merged 4 commits into from
May 2, 2024
Merged

Deprecate conda.plan #13881

merged 4 commits into from
May 2, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 1, 2024 •
edited

Description

Moves functions still in use (to where they are used):

  • conda.plan._get_best_prec_match → conda.misc._get_best_prec_match
  • conda.plan.revert_actions → conda.cli.install.revert_actions

Deprecates unused functions:

  • conda.plan.print_dists
  • conda.plan.display_actions
  • conda.plan.add_unlink
  • conda.plan.add_defaults_to_specs
  • conda.plan.execute_actions
  • conda.plan._plan_from_actions
  • conda.plan._inject_UNLINKLINKTRANSACTION
  • conda.plan._handle_menuinst
  • conda.plan.install_actions
  • conda.plan.get_blank_actions
  • conda.plan as an entrypoint

Extends #13869
Resolves #12421

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added this to the 24.5.x milestone May 1, 2024
@kenodegard kenodegard requested a review from beeankha May 1, 2024 19:57
@kenodegard kenodegard self-assigned this May 1, 2024
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 1, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 1, 2024 •
edited

CodSpeed Performance Report

Merging #13881 will not alter performance

Comparing kenodegard:deprecate-plan (e35bc25) with 24.5.x (7f4ddde)

Summary

✅ 21 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review May 2, 2024 15:42
@kenodegard kenodegard requested a review from a team as a code owner May 2, 2024 15:42
jezdez
jezdez previously approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

conda/misc.py Outdated Show resolved Hide resolved
conda/misc.py Outdated Show resolved Hide resolved
conda/cli/install.py Outdated Show resolved Hide resolved
@kenodegard @jezdez
Apply suggestions from code review
e35bc25 
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@kenodegard kenodegard enabled auto-merge (squash) May 2, 2024 16:44
@kenodegard kenodegard merged commit e048f31 into conda:24.5.x May 2, 2024
68 checks passed
@kenodegard kenodegard deleted the deprecate-plan branch May 2, 2024 18:33
@beeankha beeankha mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeankha beeankha beeankha approved these changes

@jezdez jezdez jezdez left review comments

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
24.5.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kenodegard @jezdez @beeankha @conda-bot