Add dependencies even if strictness == 3

[mcg1969]

This directly addresses #918, and is now more reasonable in light of the performance improvements provided by #1702 ...

[mcg1969]

A test is failing, but for exactly the reason it should: because it is including additional dependencies. I'll double-check the results manually and modify the test code.

[mcg1969]

This fix does balloon the number of dependencies pulled in. I think that's because generate_version_eq is bypassing the pruning step. So this doesn't necessarily reflect a significant degradation of performance in active use.

[mcg1969]

I'm going to modify the tests another time, this time to use get_dists(specs, filtered=True). Stay tuned.

[mcg1969]

OK, I made the filtered=True change locally, but I'm not going to push it up. Here's why: the pruning pass is so good that it effectively renders this test useless. That is to say, generate_version_eq returns an empty list in the include0=False case. So it's better to leave the unfiltered case in the test, so that it properly exercises things.

Bottom line: we should go ahead with this, under the reasonably safe guess that the new pruning pass has resolved the performance issues that dictated the hack/bug in the first place.

[pelson]

Given there is a simple revert strategy if this results in a major degradation in performance, and this is clearly a bug fixed, I'm 👍

[dhirschfeld]

The AssertionError/MatchSpec bug has been a huge source of completely inscrutable install issues for me so I'm +:100: on getting this fix in a release soon!

[msarahan]

Thanks, @mcg1969

[whitequark]

Any idea when this will be in a released version?

[rekcahpassyla]

We may need this enough to go with a non-released build for a bit.. I tried to build using https://github.com/conda/conda-recipes/tree/master/conda but ran into lots of problems. Is there documentation about how to build locally?

[pelson]

Did this recently for py3k on the raspberrypi. Take a look at https://github.com/pelson/raspberrypi-conda-recipes/tree/master/recipes/conda.

[rekcahpassyla]

@pelson Thank you, will try to adapt that.

[rekcahpassyla]

Just noticed https://github.com/conda/conda/releases/tag/3.18.4 - many thanks.

[asmeurer]

Glad you were able to change this. You probably should add the test from 3077dc1.

[mcg1969]

Ah, great, thanks!

[github-actions]

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.