Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Grayskull removes comma from version #482

Closed
BastianZim opened this issue Aug 21, 2023 · 4 comments · Fixed by #488
Closed

[BUG] Grayskull removes comma from version #482

BastianZim opened this issue Aug 21, 2023 · 4 comments · Fixed by #488
Assignees
Labels
bug Something isn't working

Comments

@BastianZim
Copy link
Contributor

BastianZim commented Aug 21, 2023

Describe the bug
A clear and concise description of what the bug is.

Every time Grayskull auto-update is run on one recipe of mine, it removes the comma in a version

Example PR: conda-forge/transformer-smaller-training-vocab-feedstock#6
Commit that removed it: conda-forge/transformer-smaller-training-vocab-feedstock@b47fc5b
Commit that fixed it conda-forge/transformer-smaller-training-vocab-feedstock@3fb622e

Expected behavior
A clear and concise description of what you expected to happen.

COmma should stay

Outputs
If applicable, add the output to help explain your problem.

Environment:

  • conda list
  • pip list
  • grayskull --version

Conda-forge smithy auto update of PRs.

Additional context
Add any other context about the problem here.

@BastianZim BastianZim added the bug Something isn't working label Aug 21, 2023
@BastianZim BastianZim changed the title [BUG] Grayskull removes comma [BUG] Grayskull removes comma from version Aug 21, 2023
@marcelotrevisani marcelotrevisani self-assigned this Sep 14, 2023
@marcelotrevisani
Copy link
Member

@marcelotrevisani
Copy link
Member

I can add a workaround for it, but grayskull just got what the metadata informed.

@marcelotrevisani
Copy link
Member

I create a PR upstream and added some code to do a workaround in case if this problem occur again.

@BastianZim
Copy link
Contributor Author

Ahh ok. Thank you very much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants