-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOW_WE_USE_GITHUB.md
: Updates to working with issues, labeling and other general updates
#728
Conversation
Added section on Working on Tickets; updated information on labels to highlight mandatory labels, include information on label descriptions and provide a general overview of the three mandatory label categories; separated out information on the process of issue sorting from information on what information sorting actually is; added information on spikes; changed infra --> infrastructure, in line with current repo name
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. I left a couple suggestions and comments.
changed link to global labels workflow to link to labels page, along with instructions for how to get to each repo's labels page
doubtful it will work tbh
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, we're almost there!
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
It's my review. I don't want it to hold anything up.
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
HOW_WE_USE_GITHUB.md
: Updates to working with tickets, labeling and general updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some feedback around the confusing use of both "tickets" and "issues". GitHub uses the term "issue" and we shouldn't conflate the two and stick with one.
@jezdez good call on conforming to using issue and not ticket I remember struggling with this since its weird talking about a feature request as an issue or phrasing things like "if you have an issue, open an issue" |
HOW_WE_USE_GITHUB.md
: Updates to working with tickets, labeling and general updatesHOW_WE_USE_GITHUB.md
: Updates to working with issues, labeling and other general updates
Co-authored-by: Jannis Leidel <jannis@leidel.info>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
suggested changes were incorporated
Added section to
How_We_Use_Github.md
on Working on Tickets; updated information on labels to highlight mandatory labels, include information on label descriptions and provide a general overview of the three mandatory label categories; separated out information on the process of issue sorting from information on what information sorting actually is; added information on spikes; changed infra --> infrastructure, in line with current repo nameDescription
Resolves #677
Working on Tickets
, beginning on line 293)source::* labels
(see sectionWhat labels are required for each issue?
, beginning on line 160)