Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOW_WE_USE_GITHUB.md: Updates to working with issues, labeling and other general updates #728

Merged
merged 26 commits into from
Apr 28, 2023

Conversation

kalawac
Copy link
Contributor

@kalawac kalawac commented Mar 15, 2023

Added section to How_We_Use_Github.md on Working on Tickets; updated information on labels to highlight mandatory labels, include information on label descriptions and provide a general overview of the three mandatory label categories; separated out information on the process of issue sorting from information on what information sorting actually is; added information on spikes; changed infra --> infrastructure, in line with current repo name

Description

Resolves #677

  • Added instructions on how to assign yourself to a ticket you are actively reviewing (see section Working on Tickets, beginning on line 293)
  • Added Instructions for how to use the source::* labels (see section What labels are required for each issue?, beginning on line 160)
  • Reviewed provided templates for answering an issue: no change made
  • Changed references to conda/infra to conda/infrastructure (current repo name)
  • Added information to section on spikes

Added section on Working on Tickets; updated information on labels to highlight mandatory labels, include information on label descriptions and provide a general overview of the three mandatory label categories; separated out information on the process of issue sorting from information on what information sorting actually is; added information on spikes; changed infra --> infrastructure, in line with current repo name
@kalawac kalawac requested a review from a team as a code owner March 15, 2023 20:22
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 15, 2023
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. I left a couple suggestions and comments.

@kalawac kalawac changed the title Updates to working with tickets, labelling and gen updates How_We_Use_GitHub.md: Updates to working with tickets, labelling and gen updates Mar 22, 2023
changed link to global labels workflow to link to labels page, along with instructions for how to get to each repo's labels page
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, we're almost there!

HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
kalawac and others added 4 commits March 22, 2023 17:20
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@travishathaway travishathaway dismissed their stale review March 24, 2023 11:25

It's my review. I don't want it to hold anything up.

Co-authored-by: Ken Odegard <kodegard@anaconda.com>
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
@kenodegard kenodegard changed the title How_We_Use_GitHub.md: Updates to working with tickets, labelling and gen updates HOW_WE_USE_GITHUB.md: Updates to working with tickets, labeling and general updates Apr 28, 2023
kenodegard
kenodegard previously approved these changes Apr 28, 2023
beeankha
beeankha previously approved these changes Apr 28, 2023
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some feedback around the confusing use of both "tickets" and "issues". GitHub uses the term "issue" and we shouldn't conflate the two and stick with one.

HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
@kenodegard
Copy link
Contributor

@jezdez good call on conforming to using issue and not ticket

I remember struggling with this since its weird talking about a feature request as an issue or phrasing things like "if you have an issue, open an issue"

@kenodegard kenodegard changed the title HOW_WE_USE_GITHUB.md: Updates to working with tickets, labeling and general updates HOW_WE_USE_GITHUB.md: Updates to working with issues, labeling and other general updates Apr 28, 2023
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@kenodegard kenodegard dismissed stale reviews from beeankha and themself via d3f16cb April 28, 2023 14:57
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
HOW_WE_USE_GITHUB.md Outdated Show resolved Hide resolved
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@kenodegard kenodegard dismissed kathatherine’s stale review April 28, 2023 21:50

suggested changes were incorporated

@kenodegard kenodegard merged commit 27bc7db into conda:main Apr 28, 2023
3 checks passed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update HOW_WE_USE_GITHUB Document
7 participants