-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commands with arguments that start with "-" #182
Conversation
Parameters that start with "-" are interpreted as a new argument. argparse.REMAINDER forces it to interpret all everything left in the command as a list of strings instead of new arguments. Fixes issue conda#177
We require contributors to sign our Contributor License Agreement and we don't have one on file for @JTignor-Raltron. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#871), and ping the bot to refresh the PR. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Thanks! I added some basic tests to make sure the fix doesn't break anything else. Once you have signed the CLA, we can merge this! |
@jaimergp Good call, I thought about that but without knowing how your testing infrastructure is set up it would have taken me significantly longer than it took you. I did already sign the CLA, it looks like it's waiting for someone to verify that I signed so that PR can be merged? |
@conda-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Parameters that start with "-" are interpreted as a new argument. argparse.REMAINDER forces it to interpret all everything left in the command as a list of strings instead of new arguments. Fixes issue #177