Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands with arguments that start with "-" #182

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

JTignor-Raltron
Copy link
Contributor

Parameters that start with "-" are interpreted as a new argument. argparse.REMAINDER forces it to interpret all everything left in the command as a list of strings instead of new arguments. Fixes issue #177

Parameters that start with "-" are interpreted as a new argument. argparse.REMAINDER forces it to interpret all everything left in the command as a list of strings instead of new arguments. Fixes issue conda#177
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @JTignor-Raltron.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#871), and ping the bot to refresh the PR.

@jaimergp
Copy link
Contributor

pre-commit.ci autofix

@jaimergp
Copy link
Contributor

pre-commit.ci autofix

tests/_legacy/test_cwp.py Outdated Show resolved Hide resolved
@jaimergp
Copy link
Contributor

Thanks!

I added some basic tests to make sure the fix doesn't break anything else. Once you have signed the CLA, we can merge this!

@JTignor-Raltron
Copy link
Contributor Author

@jaimergp Good call, I thought about that but without knowing how your testing infrastructure is set up it would have taken me significantly longer than it took you.

I did already sign the CLA, it looks like it's waiting for someone to verify that I signed so that PR can be merged?

@dbast
Copy link
Member

dbast commented Jan 26, 2024

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 26, 2024
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaimergp jaimergp merged commit cd9fbca into conda:main Jan 26, 2024
18 checks passed
@jaimergp jaimergp linked an issue Jan 26, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CWP change to argparse breaks shortcuts to execute module with -m option
4 participants