Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.4 did not include any actual changes #70

Closed
Tracked by #73
maksverver opened this issue Sep 5, 2023 · 0 comments
Closed
Tracked by #73

Release 0.6.4 did not include any actual changes #70

maksverver opened this issue Sep 5, 2023 · 0 comments
Assignees
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::community catch-all for issues filed by community members type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package

Comments

@maksverver
Copy link

maksverver commented Sep 5, 2023

What happened?

It looks like tag 0.6.4 was made to the wrong commit. It includes a version bump but not the actual changes described in the changelog.

$ git diff 0.6.3 0.6.4 pycosat.c CHANGELOG 
diff --git a/CHANGELOG b/CHANGELOG
index d3ad430..4f58110 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,8 @@
+2022-10-24   0.6.4:
+-------------------
+  * Fix memory leak in blocksol() when iterating over solutions
+
+
 2017-10-29   0.6.3:
 -------------------
   * Revert 'always use Python memory manager'
diff --git a/pycosat.c b/pycosat.c
index 2197176..bc130c0 100644
--- a/pycosat.c
+++ b/pycosat.c
@@ -5,7 +5,7 @@
   uses an MIT style license.
 */
 #define PYCOSAT_URL  "https://pypi.python.org/pypi/pycosat"
-#define PYCOSAT_VERSION  "0.6.3"
+#define PYCOSAT_VERSION  "0.6.4"
 
 #include <Python.h>

It seems like the intent was to include commit 537448e which fixed the memory leak reported in #38 and fixed in #54, but that's not actually in the release. Those changes do exist at HEAD, though.

Could you please create a new release that includes the latest changes?

@maksverver maksverver added the type::bug describes erroneous operation, use severity::* to classify the type label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Sep 5, 2023
@kenodegard kenodegard added source::community catch-all for issues filed by community members type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package in-progress issue is actively being worked on and removed type::bug describes erroneous operation, use severity::* to classify the type labels Sep 5, 2023
@dholth dholth moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Sep 5, 2023
@dholth dholth mentioned this issue Sep 28, 2023
21 tasks
@dholth dholth closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🏁 Done in 🧭 Planning Oct 3, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::community catch-all for issues filed by community members type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

No branches or pull requests

3 participants