Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conductor API for updateWorkflowDef doesn't support updating onStateChange values #237

Closed
matteius opened this issue Jan 6, 2024 · 1 comment

Comments

@matteius
Copy link
Contributor

matteius commented Jan 6, 2024

Conductor API for updateWorkflowDef doesn't support updating onStateChange values.

        task.on_state_change = {
            "onScheduled,onStart,onSuccess,onFailed,onCancelled": [
                {
                    "type": "task_status_changed",
                    "payload": {"task": "${%s}" % task.task_reference_name, "workflow": "${workflow}"},
                }
            ]
        }

but updated workflow is missing this data because client doesn't have getter/setter for this newer attribute.

@v1r3n
Copy link
Member

v1r3n commented Jan 17, 2024

Hi @matteius this has been addressed in the latest version. See https://github.com/conductor-sdk/conductor-python/blob/main/examples/task_status_change_audit.py for example.

@v1r3n v1r3n closed this as completed Jan 17, 2024
@v1r3n v1r3n reopened this Jan 17, 2024
@v1r3n v1r3n closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants