Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light grey color on the Mail Toolbar... #22

Closed
DXNWO opened this issue Nov 3, 2018 · 27 comments
Closed

Light grey color on the Mail Toolbar... #22

DXNWO opened this issue Nov 3, 2018 · 27 comments
Labels
enhancement New feature or request

Comments

@DXNWO
Copy link

DXNWO commented Nov 3, 2018

Can the light grey color on the Mail Toolbar and the light grey color when composing a new message be changed to a darker color? Such as, the dark color in the built-in dark theme (see screenshots). Thanks.

image

image

@conema conema added the enhancement New feature or request label Nov 3, 2018
@Cri85
Copy link

Cri85 commented Nov 9, 2018

I agree. Also the tab "today", "yesterday" etc. in the mail list are too light, the white text can not be read

@conema
Copy link
Owner

conema commented Nov 10, 2018

Hi @Cri85, I saw that you are a graphic designer, I would thank you if you could find some time for create a new palette for the theme!

@Cri85
Copy link

Cri85 commented Nov 10, 2018

Hi @Cri85, I saw that you are a graphic designer, I would thank you if you could find some time for create a new palette for the theme!

Yes, I can do it, but I have no idea how works the theme customization...

Using Photoshop I can see that the primary palette is this:
immagine

I like it, but some text need more contrast because the background is too light or dark.

@conema
Copy link
Owner

conema commented Nov 10, 2018

The real problem is that with the new version of TB, full themes will stop working (see #23), so, at the moment, I don't know if it's a clever thing to continue to develop this theme.

@CountQuadula
Copy link

CountQuadula commented Nov 12, 2018

Monterail Full Dark + TB 60.3.0
This is a nice design except for the "light grey" header.
I've seen hints that this can be edited, but no tutorial. Please link detail instruction on how to change the color to darker grey. Thanks!

To help others

Go to the "extensions" folder, here there should be a file named "MonterailFullDark@conema.me.xpi"
While Thunderbird is opened in background, delete the "MonterailFullDark@conema.me.xpi" file.

This file would not delete while TB was open. A workaround is to Drag the file to the Desktop, then Delete it.

@conema
Copy link
Owner

conema commented Nov 13, 2018

Monterail Full Dark + TB 60.3.0
This is a nice design except for the "light grey" header.
I've seen hints that this can be edited, but no tutorial. Please link detail instruction on how to change the color to darker grey. Thanks!

Open with a zip/rar tool the file named "MonterailFullDark@conema.me.xpi", that is located into "extensions" folder (TB must be closed). Open chrome/MonterailOverlay/css/root.css and edit the 17th row that should have --background-color-light: #838689;, change #838689 with the color that you want. Save the file & start TB.

To help others

Go to the "extensions" folder, here there should be a file named "MonterailFullDark@conema.me.xpi"
While Thunderbird is opened in background, delete the "MonterailFullDark@conema.me.xpi" file.

This file would not delete while TB was open. A workaround is to Drag the file to the Desktop, then Delete it.

That depends from the OS, but yes, in Windows the file can't be deleted while TB is opened.

@DXNWO
Copy link
Author

DXNWO commented Nov 13, 2018

Hello Conema, thanks for the information. I was able to change the the light grey on the Mail Toolbar to a darker color with the instructions you provided (see below).

mont1

@DXNWO
Copy link
Author

DXNWO commented Nov 13, 2018

Once again, thanks for the information. I noticed an odd font color change after making the change from earlier. I need to elaborate, the font color changes in the “To” and “Subject” fields. If either those fields are selected the text color is white but if neither are selected then the text turns black. This makes it hard to see with the dark color change previously described. See screenshots below, thanks again.

mont2

mont3

@conema
Copy link
Owner

conema commented Nov 13, 2018

Once again, thanks for the information. I noticed an odd font color change after making the change from earlier. I need to elaborate, the font color changes in the “To” and “Subject” fields. If either those fields are selected the text color is white but if neither are selected then the text turns black. This makes it hard to see with the dark color change previously described. See screenshots below, thanks again.

Resolved with the last commit, remember that if you update the theme, you should re-edit the root.css file. Let me know if all is okay.

PS: Open a new issue if you have any other issues.

@CountQuadula
Copy link

I have the same issue. How to fix the black text?
"Resolved with the last commit" what does that mean?

@conema
Copy link
Owner

conema commented Nov 14, 2018

I have the same issue. How to fix the black text?
"Resolved with the last commit" what does that mean?

That means that the files on this repository are been updated. These files may/may not be ready for automatic updates, for this one, it's not ready and you should update the theme with the manual installation mode (Download the file from the repo, zip the file -not the monterail-fulldark directory-, rename the zip as .xpi and install it through TB).

@DXNWO
Copy link
Author

DXNWO commented Nov 14, 2018

Hello Conema, thank you for updating the compose.css. Font/text color is good now in the To & Subject fields, great job.

@CountQuadula
Copy link

Download is 617kb, but TB is giving error"won't install because the file is corrupt".

@conema
Copy link
Owner

conema commented Nov 15, 2018

Download is 617kb, but TB is giving error"won't install because the file is corrupt".

May you send me a screenshot of the .xpi content?

@CountQuadula
Copy link

Screenshot of TB
tb_addon

@conema
Copy link
Owner

conema commented Nov 16, 2018

As I said in my last comment, you should make a zip with the content of monterail-fulldark-master.
So you should take the files and folder in the screenshot, create a zip file with only them into and rename it to .xpi. (Now you have .xpi->monterail-fulldark-master->files/folder (chrome/chrome.manifest/icon.png/etc...), you should have .xpi->files/folder)
immagine

@conema
Copy link
Owner

conema commented Nov 17, 2018

@CountQuadula The update is being released with automatic update, so you can wait for it, just one/two day!

PS: Update is now available

@CountQuadula
Copy link

CountQuadula commented Nov 17, 2018

Thanks Conema, Apologies, I clearly misunderstood the instructions. This is not something I typically work on. Thanks for your patience. Now that i've edited the color to: #090909, it looks great! Thanks for the fix.

@CountQuadula
Copy link

The main (root) window is still blaring white, what controls that color?
tb_main

@conema
Copy link
Owner

conema commented Nov 17, 2018

Thanks Conema, Apologies, I clearly misunderstood the instructions. This is not something I typically work on. Thanks for your patience. Now that i've edited the color to: #090909, it looks great! Thanks for the fix.

No problem!

The main (root) window is still blaring white, what controls that color?

This can't be done by changing some theme variable like last time, you should change the background/text color of the #acctCentralGrid container with CSS. Something like
#acctCentralGrid { background-color: #some-color; color: #some-color; }

@CountQuadula
Copy link

Haha, Yea, I'm lost already. Where is "#acctCentralGrid container "?

@conema
Copy link
Owner

conema commented Nov 17, 2018

Haha, Yea, I'm lost already. Where is "#acctCentralGrid container "?

Open the same file as before, root.css, go at the end of the file, after the last } and paste this: #acctCentralGrid { background-color: #some-color; color: #some-color; }. Remember to change #some-color, with the color that you want. Save the file and do the same thing that you did for changing the other color (zip, xpi, etc...).

PS: If you want more help to learn of to tweak things, you should go to mozillazine, a forum about this sort of things

@CountQuadula
Copy link

There are two "#some-color;" Do they need to be the same Color?
e.g.
} #acctCentralGrid { background-color: #090909r; color: #090909; }

@conema
Copy link
Owner

conema commented Nov 19, 2018

There are two "#some-color;" Do they need to be the same Color?
e.g.
} #acctCentralGrid { background-color: #090909r; color: #090909; }

Nope, "background-color" is for the background, "color" is for the text color

@CountQuadula
Copy link

Here is the last two code lines, I've tried it with "} ." and without "." with no change.
`#facet-date text {
fill: var(--headers-background-color);
}

/* TB Mail Main Screen */
#acctCentralGrid {
background-color: #363636; color: #838689;

}`

@conema
Copy link
Owner

conema commented Nov 20, 2018

Here is the last two code lines, I've tried it with "} ." and without "." with no change.
`#facet-date text {
fill: var(--headers-background-color);
}

/* TB Mail Main Screen */
#acctCentralGrid {
background-color: #363636; color: #838689;

}`

Mhmh, I think that it's better to put this code into userChrome.css, but it's a thing that doesn't concern the theme, so you would find more useful to open a thread on mozillazine to ask for help!

@conema conema closed this as completed in 69b545e Sep 11, 2020
@conema
Copy link
Owner

conema commented Sep 11, 2020

I changed the color in the last commit (after a long time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants