-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to expose offsetsForTimes method on Consumer #228
Comments
Should be easy to add (corresponding function exists in librdkafka) but hasn't been prioritized - you're the first person to ask for the dotnet client I think. PRs accepted :-) |
I'll take a look. Will be appreciated for docs/guidelines describing how to work with librdkafka correctly. |
Here is the corresponding Kafka improvement proposal: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868090. And the librdkafka issue: confluentinc/librdkafka#842 Also, found the similar issue #85 |
The relevant librdkafka function is Ahh yes, I forgot someone else asked for this :-). It'd be a quick win, we should do this. Any help appreciated, but I'll try to get to it sooner rather than later. |
I've started to implement this method, but stuck at passing arguments to librdkafka. Now I need to convert @mhowlett, can you give me an advice on this? Comments on current changes are also appreciated. |
Have a look in |
Pinned: java implementation is here https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L1489 |
* WIP: Implementing Consumer.OffsetsForTimes. Interacting with librdkafka * #228 Consumer.OffsetsForTimes implemented * Changes on review comments (#235) * Changes for timeout param on Consumer.OffsetsForTimes API (#235) * Bugfix: null checks in Producer ctor * Intergration test for Consumer.OffsetsForTimes added (#235) * Unit tests added for TopicPartitionTimestamp (#235) * changes on codereview (#235) * argument renaming in rd_kafka_offsets_for_times (#235) * fixed incorrect merge * removed space * changes on codereview (#235) * small code cleaning in tests * minor changes
Any plans to release this method? I can't find it in "0.11.0.x" branch :-( |
it will be in the next major release, or you can use a package from the appveyor nuget feed. |
Sorry, do we have sample usage of OffsetFortimes event in .net code? Thank you |
Java consumer API has the method
which helps to assign a consumer to a specified offset based on timestamp.
Is there any plans to support this in .NET API?
The text was updated successfully, but these errors were encountered: