Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert call to Apache Kafka ofTimeAndGracePeriod() #8047

Merged
merged 1 commit into from
Aug 24, 2021
Merged

chore: revert call to Apache Kafka ofTimeAndGracePeriod() #8047

merged 1 commit into from
Aug 24, 2021

Conversation

spena
Copy link
Member

@spena spena commented Aug 24, 2021

Description

#7678 reverted the GRACE PERIOD from joins, but it did not include the removal of the call to ofTimeAndGracePeriod() from AK. This PR addresses that issue.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena requested a review from a team August 24, 2021 15:11
vvcephei
vvcephei approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @spena !

@spena spena merged commit 4c54980 into master Aug 24, 2021
@spena spena deleted the revert_ak_grace_call branch August 24, 2021 17:57
spena added a commit that referenced this pull request Aug 24, 2021
@spena @ConfluentJenkins
chore: revert call to ofTimeAndGracePeriod() (#8047)
7e9d2a1
@spena spena mentioned this pull request Aug 24, 2021
Merged
2 tasks
@ableegoldman
Copy link
Contributor

@vvcephei @spena We need to remember to un-revert these changes in master (same for #8028) since we only backed out the new JoinWindows API and deprecation of the old one in 3.0/7.0 -- it's still there in AK trunk/ccs-kafka master

mjsax pushed a commit to mjsax/ksql that referenced this pull request Oct 5, 2021
@spena @mjsax
chore: revert call to ofTimeAndGracePeriod() (confluentinc#8047)
75bbd1b
@mjsax mjsax mentioned this pull request Oct 5, 2021
Closed
spena pushed a commit that referenced this pull request Oct 6, 2021
@ConfluentJenkins
Revert "chore: revert call to ofTimeAndGracePeriod() (#8047)"
2ae4579 
Re-enable stream-stream left/outer joins fixes again.

This reverts commit 4c54980.
spena added a commit that referenced this pull request Oct 7, 2021
@spena
feat: Re-enable GRACE period with new stream-stream joins semantics (#…
f640f5e 
…8236)

Re-enable stream-stream left/outer joins fixes again.

* Revert "Revert GRACE keyword in Joins (#8020) (#8027)"
This reverts commit dac6e38.

* Revert "chore: revert GRACE PERIOD from joins (#8028)"
This reverts commit c17ce67.

* Revert "chore: revert call to ofTimeAndGracePeriod() (#8047)"
This reverts commit 4c54980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvcephei vvcephei vvcephei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spena @ableegoldman @vvcephei @ConfluentJenkins