Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Improvements] Log HttpListenerException in HttpServer.cs ConnectionThreadStart method #738

Open
Ryujose opened this issue Aug 14, 2022 · 2 comments

Comments

@Ryujose
Copy link

Ryujose commented Aug 14, 2022

Hi guys.

I found this exception without any logging, it only have a print for a console env. I think that it could be useful to log this point to let the end-user know what exactly is happening.

image

@gbirchmeier
Copy link
Member

gbirchmeier commented Feb 5, 2024

I'm realizing that QF/n's current logging interface might be too limited.

It's obvious to me that this should be loggable, but the normal QF/n log interface ties each log to a Session, and HttpServer does not apply to any session. So how should this HttpServer log be configured? It doesn't seem wise to just hack something out right now. I'm going to think about it for a little while (and hopefully come back to this before another year has passed).

@gbirchmeier
Copy link
Member

gbirchmeier commented Feb 5, 2024

On the upside, I just rewrote the whole dang HttpServer (#829), and it now handles exeptions much better, so ideally there won't be any unexpected shutdowns to need to log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants