Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all deps to newest version #45

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Update all deps to newest version #45

merged 2 commits into from
Aug 12, 2022

Conversation

tlbdk
Copy link
Member

@tlbdk tlbdk commented Aug 9, 2022

@tlbdk tlbdk requested a review from mex August 9, 2022 15:05
Copy link
Contributor

@mex mex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tried running with these versions in one of the larger TS repos? Just to make sure we are not requiring a bunch of changes to support v28 instead of v27 in Jest.

By the way a GitHub check is failing for some code scanning that I haven't seen before.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tlbdk
Copy link
Member Author

tlbdk commented Aug 10, 2022

The github check that failed is some github security scanning tool you can use on public repos.

@mex
Copy link
Contributor

mex commented Aug 11, 2022

After having added it to job-runner-cleanup, the only interesting change I stumbled upon was the change below due to @types/node having removed NodeJS.Global from v16 and onward. Though this is technically not due to this PR as it was already on v17 before.

Before:

import { DatabaseIntegrationTest } from '@connectedcars/data'

export interface Global extends NodeJS.Global {
  databaseIntegrationTest: DatabaseIntegrationTest
}

After:

import { DatabaseIntegrationTest } from '@connectedcars/data'

type NodeJSGlobal = typeof global
export interface Global extends NodeJSGlobal {
  databaseIntegrationTest: DatabaseIntegrationTest
}

@mex mex merged commit bf7dcc3 into master Aug 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-2022-08-09 branch August 12, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants