Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil values in generated protobufs #410

Open
matejpavlovic opened this issue Apr 19, 2023 · 0 comments
Open

Nil values in generated protobufs #410

matejpavlovic opened this issue Apr 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@matejpavlovic
Copy link
Contributor

matejpavlovic commented Apr 19, 2023

The Pb() method of types generated from protobufs panics if there is a nil value in some of the object's fields.
The generated code should be adapted so that nil values are faithfully reproduced.

At least, even without support for nil values, at least make the conversions happen in one place and gracefully ignore those conversions that could fail due to some other node being faulty.

@matejpavlovic matejpavlovic added the bug Something isn't working label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant