Manage offices url as a setting #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferblape
force-pushed
the
1315-manage-offices_url-as-setting
branch
from
55d31c6
to
ca2370e
Compare
xuanxu
requested changes
Jan 2, 2017
| @@ -50,7 +50,7 @@ | |||
| <ul> | |||
| <li> | |||
| <%= t("verification.letter.new.office", | |||
| office: link_to(t("verification.letter.new.offices"), t("verification.letter.new.offices_url"), | |||
| office: link_to(t("verification.letter.new.offices"), Setting['verification_offices_url'], | |||
There was a problem hiding this comment.
Please use setting['verification_offices_url'] instead.
There is a setting helper method to use in views and have the settings memoized per request.
xuanxu
approved these changes
Jan 3, 2017
mlovic
pushed a commit
to wairbut-m2c/consul
that referenced
this pull request
Jul 10, 2018
…m-order Fix random order for budget investments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects with #1315, and it moves the I18n key
offices_urlto a setting that can be stablished by an admin.