Simplify valuator factories #3727

javierm · 2019-09-25T15:22:25Z

Objectives

Reduce the amount of code we need to write to create valuators in the tests.

spec/models/abilities/valuator_spec.rb

spec/features/valuation/budget_investments_spec.rb

spec/models/budget/investment_spec.rb

Creating a record and then assigning an association makes the code even harder to follow.

…_factories Simplify valuator factories

javierm added the Specs label Sep 25, 2019

javierm self-assigned this Sep 25, 2019

javierm added this to Reviewing in Roadmap via automation Sep 25, 2019

houndci-bot reviewed Sep 25, 2019

View reviewed changes

javierm force-pushed the simplify_valuator_factories branch from a43b38f to b1f6aac Compare September 25, 2019 15:25

javierm force-pushed the attributes_in_specs branch from 7ca09df to 6cf29db Compare September 26, 2019 19:19

javierm force-pushed the simplify_valuator_factories branch from b1f6aac to a49a8ab Compare September 26, 2019 19:19

javierm force-pushed the attributes_in_specs branch from 6cf29db to cc76a4d Compare September 26, 2019 19:24

javierm force-pushed the simplify_valuator_factories branch from a49a8ab to 4cc082e Compare September 26, 2019 19:25

javierm force-pushed the attributes_in_specs branch from cc76a4d to 8fba68b Compare September 26, 2019 20:45

javierm force-pushed the simplify_valuator_factories branch from 4cc082e to 383b996 Compare September 26, 2019 20:46

javierm force-pushed the attributes_in_specs branch from 8fba68b to b722fa2 Compare September 26, 2019 20:52

javierm force-pushed the simplify_valuator_factories branch from 383b996 to 3fd0a14 Compare September 26, 2019 20:53

javierm force-pushed the attributes_in_specs branch from b722fa2 to ed45561 Compare September 26, 2019 21:12

javierm force-pushed the simplify_valuator_factories branch from 3fd0a14 to cfd4eac Compare September 26, 2019 21:13

javierm force-pushed the attributes_in_specs branch from ed45561 to 93036d4 Compare September 26, 2019 23:23

javierm force-pushed the simplify_valuator_factories branch from cfd4eac to ba20faf Compare September 26, 2019 23:23

javierm force-pushed the attributes_in_specs branch from 93036d4 to 65e6002 Compare September 26, 2019 23:28

javierm force-pushed the simplify_valuator_factories branch from ba20faf to 4d38479 Compare September 26, 2019 23:28

javierm force-pushed the attributes_in_specs branch from 65e6002 to 08931c0 Compare September 27, 2019 00:57

javierm force-pushed the simplify_valuator_factories branch from 4d38479 to 830ceb3 Compare September 27, 2019 00:57

javierm force-pushed the attributes_in_specs branch from 08931c0 to 105fa69 Compare September 27, 2019 16:34

javierm force-pushed the simplify_valuator_factories branch from 830ceb3 to 04a980a Compare September 27, 2019 16:34

javierm force-pushed the attributes_in_specs branch 2 times, most recently from 2bdcde7 to 0484318 Compare September 27, 2019 21:59

javierm force-pushed the simplify_valuator_factories branch from 04a980a to 1c92f32 Compare September 27, 2019 22:03

javierm force-pushed the attributes_in_specs branch from 0484318 to 570b753 Compare September 28, 2019 01:06

javierm force-pushed the simplify_valuator_factories branch from 1c92f32 to b287b44 Compare September 28, 2019 01:07

javierm force-pushed the attributes_in_specs branch from 570b753 to 879b5ed Compare September 28, 2019 02:42

javierm force-pushed the simplify_valuator_factories branch from b287b44 to 5dcde8d Compare September 28, 2019 02:45

javierm force-pushed the simplify_valuator_factories branch from d7db3b5 to 957512d Compare September 28, 2019 15:28

javierm force-pushed the attributes_in_specs branch from 7d89242 to 79021ee Compare September 28, 2019 15:58

javierm force-pushed the simplify_valuator_factories branch from 957512d to 73f9525 Compare September 28, 2019 15:58

javierm force-pushed the attributes_in_specs branch from 79021ee to fdf806f Compare September 28, 2019 18:35

javierm force-pushed the simplify_valuator_factories branch from 73f9525 to a9e0669 Compare September 28, 2019 18:35

javierm force-pushed the attributes_in_specs branch from fdf806f to 1a55fb6 Compare September 28, 2019 18:49

javierm force-pushed the simplify_valuator_factories branch from a9e0669 to 009f8e9 Compare September 28, 2019 18:49

javierm force-pushed the attributes_in_specs branch from 1a55fb6 to f189c97 Compare September 28, 2019 19:40

javierm force-pushed the simplify_valuator_factories branch from 009f8e9 to f9dd018 Compare September 28, 2019 19:41

javierm force-pushed the attributes_in_specs branch from f189c97 to 33cb460 Compare September 29, 2019 11:25

javierm force-pushed the simplify_valuator_factories branch from f9dd018 to acfa20a Compare September 29, 2019 11:25

javierm force-pushed the attributes_in_specs branch from 33cb460 to 9529d59 Compare September 29, 2019 13:59

javierm force-pushed the simplify_valuator_factories branch from acfa20a to dd1ebdd Compare September 29, 2019 14:00

javierm force-pushed the attributes_in_specs branch from 9529d59 to 9b14c8a Compare September 29, 2019 14:08

javierm force-pushed the simplify_valuator_factories branch from dd1ebdd to 19a395a Compare September 29, 2019 14:08

javierm force-pushed the attributes_in_specs branch from 9b14c8a to 0b80d26 Compare September 29, 2019 15:06

javierm force-pushed the simplify_valuator_factories branch from 19a395a to 11ba662 Compare September 29, 2019 15:06

javierm force-pushed the attributes_in_specs branch from 0b80d26 to 2e74ab8 Compare September 29, 2019 22:40

javierm force-pushed the simplify_valuator_factories branch from 11ba662 to 15568ca Compare September 29, 2019 22:43

javierm force-pushed the attributes_in_specs branch from 2e74ab8 to 1ebfa04 Compare September 30, 2019 12:29

javierm added 2 commits September 30, 2019 15:08

Directly assign valuators in specs

a9159e0

Creating a record and then assigning an association makes the code even harder to follow.

Add trait to create an investment with a valuator

05f63ca

javierm force-pushed the simplify_valuator_factories branch from 15568ca to 4965814 Compare September 30, 2019 13:08

javierm changed the base branch from attributes_in_specs to master September 30, 2019 13:08

Directly assign valuator groups in specs

c6808c9

javierm force-pushed the simplify_valuator_factories branch from 4965814 to c6808c9 Compare September 30, 2019 13:21

javierm merged commit a1670e2 into master Sep 30, 2019

Roadmap automation moved this from Reviewing to Release 1.1.0 Sep 30, 2019

javierm deleted the simplify_valuator_factories branch September 30, 2019 13:58

smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020

Merge pull request consuldemocracy#3727 from consul/simplify_valuator…

9ddc3e2

…_factories Simplify valuator factories

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify valuator factories #3727

Simplify valuator factories #3727

javierm commented Sep 25, 2019

Simplify valuator factories #3727

Simplify valuator factories #3727

Conversation

javierm commented Sep 25, 2019

Objectives