-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify valuator factories #3727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 25, 2019
a43b38f
to
b1f6aac
Compare
7ca09df
to
6cf29db
Compare
b1f6aac
to
a49a8ab
Compare
6cf29db
to
cc76a4d
Compare
a49a8ab
to
4cc082e
Compare
cc76a4d
to
8fba68b
Compare
4cc082e
to
383b996
Compare
8fba68b
to
b722fa2
Compare
383b996
to
3fd0a14
Compare
b722fa2
to
ed45561
Compare
3fd0a14
to
cfd4eac
Compare
ed45561
to
93036d4
Compare
cfd4eac
to
ba20faf
Compare
93036d4
to
65e6002
Compare
ba20faf
to
4d38479
Compare
65e6002
to
08931c0
Compare
4d38479
to
830ceb3
Compare
08931c0
to
105fa69
Compare
830ceb3
to
04a980a
Compare
2bdcde7
to
0484318
Compare
04a980a
to
1c92f32
Compare
0484318
to
570b753
Compare
1c92f32
to
b287b44
Compare
570b753
to
879b5ed
Compare
b287b44
to
5dcde8d
Compare
d7db3b5
to
957512d
Compare
7d89242
to
79021ee
Compare
957512d
to
73f9525
Compare
79021ee
to
fdf806f
Compare
73f9525
to
a9e0669
Compare
fdf806f
to
1a55fb6
Compare
a9e0669
to
009f8e9
Compare
1a55fb6
to
f189c97
Compare
009f8e9
to
f9dd018
Compare
f189c97
to
33cb460
Compare
f9dd018
to
acfa20a
Compare
33cb460
to
9529d59
Compare
acfa20a
to
dd1ebdd
Compare
9529d59
to
9b14c8a
Compare
dd1ebdd
to
19a395a
Compare
9b14c8a
to
0b80d26
Compare
19a395a
to
11ba662
Compare
0b80d26
to
2e74ab8
Compare
11ba662
to
15568ca
Compare
2e74ab8
to
1ebfa04
Compare
Creating a record and then assigning an association makes the code even harder to follow.
15568ca
to
4965814
Compare
4965814
to
c6808c9
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…_factories Simplify valuator factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Reduce the amount of code we need to write to create valuators in the tests.