Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify valuator factories #3727

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Simplify valuator factories #3727

merged 3 commits into from
Sep 30, 2019

Commits on Sep 30, 2019

  1. Directly assign valuators in specs 

    Creating a record and then assigning an association makes the code even
harder to follow.
    @javierm
    javierm committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a9159e0 View commit details
    Browse the repository at this point in the history

  2. Add trait to create an investment with a valuator

    @javierm
    javierm committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    05f63ca View commit details
    Browse the repository at this point in the history

  3. Directly assign valuator groups in specs

    @javierm
    javierm committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    c6808c9 View commit details
    Browse the repository at this point in the history