Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in several environments #3791

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Fix warnings in several environments #3791

merged 5 commits into from
Oct 23, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 23, 2019 •
edited

Objectives

  • Remove warnings because of redefining existing methods in the production environment
  • Fix wrong link and modal dialog references in tests
  • Make the parser gem compatible with Ruby 2.4.9

@javierm
Fix extra parameter in have_link
13793d8 
The second parameter was ignored. Besides, we changed the place where
the link pointed to in commit fcbb11b.
@javierm
Bump parser to 2.6.5.0
48cbb93 
This version is compatible with Ruby 2.4.9.
@javierm
Fix modal text warning in answers documents spec
b0d1d00 
It looks like we get this warning if we check the dialog message. Using
`accept_confirm` the same way we do in the rest of the application
solves the problem.
@javierm
Remove redundant scopes
26e050b 
These scopes were already defined by the `enum :task` method.
@javierm
Avoid "Overwriting existing method open" warning
69e3e67 
In Ruby, the Kernel class defined the `open` method, which is available
for (almost) every object. So creating a scope with the name `open`
generates a warning indicating we are overwriting the existing `open`
method.

While this warning is pretty much harmless and we could ignore it, it
generates a lot of noise in the logs. So I'm "undefining" the method
before generating the scope, so we don't get the warning all the time.
@javierm javierm self-assigned this Oct 23, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Oct 23, 2019
@javierm javierm changed the title Fix warnings we get in our logs Fix warnings in several environments Oct 23, 2019
@javierm javierm moved this from Reviewing to Testing in Roadmap Oct 23, 2019
@javierm javierm merged commit c9c89d2 into master Oct 23, 2019
Roadmap automation moved this from Testing to Release 1.1.0 Oct 23, 2019
@javierm javierm deleted the fix_warnings branch October 23, 2019 17:24
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3791 from consul/fix_warnings
2147a0c 
Fix warnings in several environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javierm javierm

Labels
Maintenance
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@javierm